Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechDebt: Migrate deploy service to aws-sdk-go-v2 #34282

Merged
merged 35 commits into from
Nov 20, 2023

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    17178f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d2b2b1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e9e7e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01d4e24 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4c0b35c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    59e81f1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    becb4e1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    08cbeb6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4ba9e38 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    99b9878 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    62a56cd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b1043c3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8e07517 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a0fe7f6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    03d950c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    260167d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67cf524 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    72bdb88 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Merge branch 'main' into HEAD

    # Conflicts:
    #	go.mod
    #	go.sum
    #	names/names_data.csv
    ewbankkit committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b9f8391 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0721cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af9838e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b549c0 View commit details
    Browse the repository at this point in the history
  5. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccDeployApp_' PKG=deploy ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployApp_ -timeout 360m
    === RUN   TestAccDeployApp_basic
    === PAUSE TestAccDeployApp_basic
    === RUN   TestAccDeployApp_computePlatform
    === PAUSE TestAccDeployApp_computePlatform
    === RUN   TestAccDeployApp_ComputePlatform_ecs
    === PAUSE TestAccDeployApp_ComputePlatform_ecs
    === RUN   TestAccDeployApp_ComputePlatform_lambda
    === PAUSE TestAccDeployApp_ComputePlatform_lambda
    === RUN   TestAccDeployApp_name
    === PAUSE TestAccDeployApp_name
    === RUN   TestAccDeployApp_tags
    === PAUSE TestAccDeployApp_tags
    === RUN   TestAccDeployApp_disappears
    === PAUSE TestAccDeployApp_disappears
    === CONT  TestAccDeployApp_basic
    === CONT  TestAccDeployApp_name
    --- PASS: TestAccDeployApp_basic (30.14s)
    === CONT  TestAccDeployApp_disappears
    --- PASS: TestAccDeployApp_name (43.35s)
    === CONT  TestAccDeployApp_ComputePlatform_ecs
    --- PASS: TestAccDeployApp_disappears (18.32s)
    === CONT  TestAccDeployApp_ComputePlatform_lambda
    --- PASS: TestAccDeployApp_ComputePlatform_ecs (24.75s)
    === CONT  TestAccDeployApp_computePlatform
    --- PASS: TestAccDeployApp_ComputePlatform_lambda (25.16s)
    === CONT  TestAccDeployApp_tags
    --- PASS: TestAccDeployApp_computePlatform (38.79s)
    --- PASS: TestAccDeployApp_tags (57.51s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	136.840s
    ewbankkit committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    fc6771b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d797688 View commit details
    Browse the repository at this point in the history
  7. Fix golangci-lint 'unused'.

    ewbankkit committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    151276e View commit details
    Browse the repository at this point in the history
  8. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccDeployDeploymentConfig_' PKG=deploy ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployDeploymentConfig_ -timeout 360m
    === RUN   TestAccDeployDeploymentConfig_basic
    === PAUSE TestAccDeployDeploymentConfig_basic
    === RUN   TestAccDeployDeploymentConfig_fleetPercent
    === PAUSE TestAccDeployDeploymentConfig_fleetPercent
    === RUN   TestAccDeployDeploymentConfig_hostCount
    === PAUSE TestAccDeployDeploymentConfig_hostCount
    === RUN   TestAccDeployDeploymentConfig_trafficCanary
    === PAUSE TestAccDeployDeploymentConfig_trafficCanary
    === RUN   TestAccDeployDeploymentConfig_trafficLinear
    === PAUSE TestAccDeployDeploymentConfig_trafficLinear
    === CONT  TestAccDeployDeploymentConfig_basic
    === CONT  TestAccDeployDeploymentConfig_trafficCanary
    --- PASS: TestAccDeployDeploymentConfig_basic (25.10s)
    === CONT  TestAccDeployDeploymentConfig_trafficLinear
    --- PASS: TestAccDeployDeploymentConfig_trafficCanary (41.82s)
    === CONT  TestAccDeployDeploymentConfig_hostCount
    --- PASS: TestAccDeployDeploymentConfig_trafficLinear (41.86s)
    === CONT  TestAccDeployDeploymentConfig_fleetPercent
    --- PASS: TestAccDeployDeploymentConfig_hostCount (42.69s)
    --- PASS: TestAccDeployDeploymentConfig_fleetPercent (39.65s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	112.410s
    ewbankkit committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f09d652 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ea23a87 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Configuration menu
    Copy the full SHA
    3ae32fb View commit details
    Browse the repository at this point in the history
  2. Replace 'validTagFilters'.

    ewbankkit committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    147e2c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a17b53a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4fd3e3e View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Fix 'TestAccDeployDeploymentGroup_Trigger_multiple' and 'TestAccDeplo…

    …yDeploymentGroup_ECS_blueGreen'.
    ewbankkit committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    32755de View commit details
    Browse the repository at this point in the history
  2. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccDeployDeploymentGroup_' PKG=deploy ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployDeploymentGroup_ -timeout 360m
    === RUN   TestAccDeployDeploymentGroup_basic
    === PAUSE TestAccDeployDeploymentGroup_basic
    === RUN   TestAccDeployDeploymentGroup_Basic_tagSet
    === PAUSE TestAccDeployDeploymentGroup_Basic_tagSet
    === RUN   TestAccDeployDeploymentGroup_onPremiseTag
    === PAUSE TestAccDeployDeploymentGroup_onPremiseTag
    === RUN   TestAccDeployDeploymentGroup_disappears
    === PAUSE TestAccDeployDeploymentGroup_disappears
    === RUN   TestAccDeployDeploymentGroup_Disappears_app
    === PAUSE TestAccDeployDeploymentGroup_Disappears_app
    === RUN   TestAccDeployDeploymentGroup_tags
    === PAUSE TestAccDeployDeploymentGroup_tags
    === RUN   TestAccDeployDeploymentGroup_Trigger_basic
    === PAUSE TestAccDeployDeploymentGroup_Trigger_basic
    === RUN   TestAccDeployDeploymentGroup_Trigger_multiple
    === PAUSE TestAccDeployDeploymentGroup_Trigger_multiple
    === RUN   TestAccDeployDeploymentGroup_AutoRollback_create
    === PAUSE TestAccDeployDeploymentGroup_AutoRollback_create
    === RUN   TestAccDeployDeploymentGroup_AutoRollback_update
    === PAUSE TestAccDeployDeploymentGroup_AutoRollback_update
    === RUN   TestAccDeployDeploymentGroup_AutoRollback_delete
    === PAUSE TestAccDeployDeploymentGroup_AutoRollback_delete
    === RUN   TestAccDeployDeploymentGroup_AutoRollback_disable
    === PAUSE TestAccDeployDeploymentGroup_AutoRollback_disable
    === RUN   TestAccDeployDeploymentGroup_Alarm_create
    === PAUSE TestAccDeployDeploymentGroup_Alarm_create
    === RUN   TestAccDeployDeploymentGroup_Alarm_update
    === PAUSE TestAccDeployDeploymentGroup_Alarm_update
    === RUN   TestAccDeployDeploymentGroup_Alarm_delete
    === PAUSE TestAccDeployDeploymentGroup_Alarm_delete
    === RUN   TestAccDeployDeploymentGroup_Alarm_disable
    === PAUSE TestAccDeployDeploymentGroup_Alarm_disable
    === RUN   TestAccDeployDeploymentGroup_DeploymentStyle_default
    === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_default
    === RUN   TestAccDeployDeploymentGroup_DeploymentStyle_create
    === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_create
    === RUN   TestAccDeployDeploymentGroup_DeploymentStyle_update
    === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_update
    === RUN   TestAccDeployDeploymentGroup_DeploymentStyle_delete
    === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_delete
    === RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_create
    === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_create
    === RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_update
    === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_update
    === RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
    === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
    === RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
    === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
    === RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
    === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
    === RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
    === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
    === RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
    === PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
    === RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
    === PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
    === RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_create
    === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_create
    === RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
    === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
    === RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_update
    === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_update
    === RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
    === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
    === RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
    === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
    === RUN   TestAccDeployDeploymentGroup_ECS_blueGreen
    === PAUSE TestAccDeployDeploymentGroup_ECS_blueGreen
    === RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
    === PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
    === RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
    === PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
    === CONT  TestAccDeployDeploymentGroup_basic
    === CONT  TestAccDeployDeploymentGroup_DeploymentStyle_update
    --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (52.12s)
    === CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
    --- PASS: TestAccDeployDeploymentGroup_basic (60.93s)
    === CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
    --- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (32.37s)
    === CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
    --- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (50.29s)
    === CONT  TestAccDeployDeploymentGroup_ECS_blueGreen
    --- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (334.32s)
    === CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
    --- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (32.81s)
    === CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
    --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (49.23s)
    === CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_update
    --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (49.91s)
    === CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
    --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (45.06s)
    === CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_create
    --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (166.66s)
    === CONT  TestAccDeployDeploymentGroup_AutoRollback_update
    --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (175.24s)
    === CONT  TestAccDeployDeploymentGroup_DeploymentStyle_create
    --- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (47.70s)
    === CONT  TestAccDeployDeploymentGroup_DeploymentStyle_default
    --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (32.36s)
    === CONT  TestAccDeployDeploymentGroup_Alarm_disable
    --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (32.35s)
    === CONT  TestAccDeployDeploymentGroup_Alarm_delete
    --- PASS: TestAccDeployDeploymentGroup_Alarm_disable (49.80s)
    === CONT  TestAccDeployDeploymentGroup_Alarm_update
    --- PASS: TestAccDeployDeploymentGroup_Alarm_delete (50.31s)
    === CONT  TestAccDeployDeploymentGroup_Alarm_create
    --- PASS: TestAccDeployDeploymentGroup_Alarm_create (33.04s)
    === CONT  TestAccDeployDeploymentGroup_AutoRollback_disable
    --- PASS: TestAccDeployDeploymentGroup_Alarm_update (49.33s)
    === CONT  TestAccDeployDeploymentGroup_AutoRollback_delete
    --- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (50.93s)
    === CONT  TestAccDeployDeploymentGroup_tags
    --- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (51.76s)
    === CONT  TestAccDeployDeploymentGroup_AutoRollback_create
    --- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (33.85s)
    === CONT  TestAccDeployDeploymentGroup_Trigger_multiple
    --- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (54.44s)
    === CONT  TestAccDeployDeploymentGroup_Trigger_basic
    --- PASS: TestAccDeployDeploymentGroup_tags (68.29s)
    === CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
    --- PASS: TestAccDeployDeploymentGroup_Trigger_basic (52.55s)
    === CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
    --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (52.66s)
    === CONT  TestAccDeployDeploymentGroup_disappears
    --- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (33.66s)
    === CONT  TestAccDeployDeploymentGroup_Disappears_app
    --- PASS: TestAccDeployDeploymentGroup_disappears (39.55s)
    === CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_update
    --- PASS: TestAccDeployDeploymentGroup_Disappears_app (30.00s)
    === CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
    --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (52.07s)
    === CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
    --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (52.45s)
    === CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_create
    --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (34.64s)
    === CONT  TestAccDeployDeploymentGroup_onPremiseTag
    --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (52.48s)
    === CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
    --- PASS: TestAccDeployDeploymentGroup_onPremiseTag (34.76s)
    === CONT  TestAccDeployDeploymentGroup_DeploymentStyle_delete
    --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (34.20s)
    === CONT  TestAccDeployDeploymentGroup_Basic_tagSet
    --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (52.19s)
    --- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (61.71s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	923.498s
    ewbankkit committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    eaafed9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e2834a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    244e35b View commit details
    Browse the repository at this point in the history