-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TechDebt: Migrate deploy
service to aws-sdk-go-v2
#34282
Merged
ewbankkit
merged 35 commits into
hashicorp:main
from
brittandeyoung:td-deploy-aws-sdk-go-v2
Nov 20, 2023
Merged
TechDebt: Migrate deploy
service to aws-sdk-go-v2
#34282
ewbankkit
merged 35 commits into
hashicorp:main
from
brittandeyoung:td-deploy-aws-sdk-go-v2
Nov 20, 2023
Commits on Nov 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 17178f7 - Browse repository at this point
Copy the full SHA 17178f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d2b2b1 - Browse repository at this point
Copy the full SHA 3d2b2b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e9e7e6 - Browse repository at this point
Copy the full SHA 4e9e7e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01d4e24 - Browse repository at this point
Copy the full SHA 01d4e24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c0b35c - Browse repository at this point
Copy the full SHA 4c0b35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59e81f1 - Browse repository at this point
Copy the full SHA 59e81f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for becb4e1 - Browse repository at this point
Copy the full SHA becb4e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08cbeb6 - Browse repository at this point
Copy the full SHA 08cbeb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba9e38 - Browse repository at this point
Copy the full SHA 4ba9e38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99b9878 - Browse repository at this point
Copy the full SHA 99b9878View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62a56cd - Browse repository at this point
Copy the full SHA 62a56cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1043c3 - Browse repository at this point
Copy the full SHA b1043c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e07517 - Browse repository at this point
Copy the full SHA 8e07517View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0fe7f6 - Browse repository at this point
Copy the full SHA a0fe7f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03d950c - Browse repository at this point
Copy the full SHA 03d950cView commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 260167d - Browse repository at this point
Copy the full SHA 260167dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67cf524 - Browse repository at this point
Copy the full SHA 67cf524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72bdb88 - Browse repository at this point
Copy the full SHA 72bdb88View commit details
Commits on Nov 17, 2023
-
# Conflicts: # go.mod # go.sum # names/names_data.csv
Configuration menu - View commit details
-
Copy full SHA for b9f8391 - Browse repository at this point
Copy the full SHA b9f8391View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0721cb - Browse repository at this point
Copy the full SHA f0721cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for af9838e - Browse repository at this point
Copy the full SHA af9838eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b549c0 - Browse repository at this point
Copy the full SHA 5b549c0View commit details -
% make testacc TESTARGS='-run=TestAccDeployApp_' PKG=deploy ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployApp_ -timeout 360m === RUN TestAccDeployApp_basic === PAUSE TestAccDeployApp_basic === RUN TestAccDeployApp_computePlatform === PAUSE TestAccDeployApp_computePlatform === RUN TestAccDeployApp_ComputePlatform_ecs === PAUSE TestAccDeployApp_ComputePlatform_ecs === RUN TestAccDeployApp_ComputePlatform_lambda === PAUSE TestAccDeployApp_ComputePlatform_lambda === RUN TestAccDeployApp_name === PAUSE TestAccDeployApp_name === RUN TestAccDeployApp_tags === PAUSE TestAccDeployApp_tags === RUN TestAccDeployApp_disappears === PAUSE TestAccDeployApp_disappears === CONT TestAccDeployApp_basic === CONT TestAccDeployApp_name --- PASS: TestAccDeployApp_basic (30.14s) === CONT TestAccDeployApp_disappears --- PASS: TestAccDeployApp_name (43.35s) === CONT TestAccDeployApp_ComputePlatform_ecs --- PASS: TestAccDeployApp_disappears (18.32s) === CONT TestAccDeployApp_ComputePlatform_lambda --- PASS: TestAccDeployApp_ComputePlatform_ecs (24.75s) === CONT TestAccDeployApp_computePlatform --- PASS: TestAccDeployApp_ComputePlatform_lambda (25.16s) === CONT TestAccDeployApp_tags --- PASS: TestAccDeployApp_computePlatform (38.79s) --- PASS: TestAccDeployApp_tags (57.51s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 136.840s
Configuration menu - View commit details
-
Copy full SHA for fc6771b - Browse repository at this point
Copy the full SHA fc6771bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d797688 - Browse repository at this point
Copy the full SHA d797688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 151276e - Browse repository at this point
Copy the full SHA 151276eView commit details -
% make testacc TESTARGS='-run=TestAccDeployDeploymentConfig_' PKG=deploy ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployDeploymentConfig_ -timeout 360m === RUN TestAccDeployDeploymentConfig_basic === PAUSE TestAccDeployDeploymentConfig_basic === RUN TestAccDeployDeploymentConfig_fleetPercent === PAUSE TestAccDeployDeploymentConfig_fleetPercent === RUN TestAccDeployDeploymentConfig_hostCount === PAUSE TestAccDeployDeploymentConfig_hostCount === RUN TestAccDeployDeploymentConfig_trafficCanary === PAUSE TestAccDeployDeploymentConfig_trafficCanary === RUN TestAccDeployDeploymentConfig_trafficLinear === PAUSE TestAccDeployDeploymentConfig_trafficLinear === CONT TestAccDeployDeploymentConfig_basic === CONT TestAccDeployDeploymentConfig_trafficCanary --- PASS: TestAccDeployDeploymentConfig_basic (25.10s) === CONT TestAccDeployDeploymentConfig_trafficLinear --- PASS: TestAccDeployDeploymentConfig_trafficCanary (41.82s) === CONT TestAccDeployDeploymentConfig_hostCount --- PASS: TestAccDeployDeploymentConfig_trafficLinear (41.86s) === CONT TestAccDeployDeploymentConfig_fleetPercent --- PASS: TestAccDeployDeploymentConfig_hostCount (42.69s) --- PASS: TestAccDeployDeploymentConfig_fleetPercent (39.65s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 112.410s
Configuration menu - View commit details
-
Copy full SHA for f09d652 - Browse repository at this point
Copy the full SHA f09d652View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea23a87 - Browse repository at this point
Copy the full SHA ea23a87View commit details
Commits on Nov 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3ae32fb - Browse repository at this point
Copy the full SHA 3ae32fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 147e2c0 - Browse repository at this point
Copy the full SHA 147e2c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a17b53a - Browse repository at this point
Copy the full SHA a17b53aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fd3e3e - Browse repository at this point
Copy the full SHA 4fd3e3eView commit details
Commits on Nov 19, 2023
-
Fix 'TestAccDeployDeploymentGroup_Trigger_multiple' and 'TestAccDeplo…
…yDeploymentGroup_ECS_blueGreen'.
Configuration menu - View commit details
-
Copy full SHA for 32755de - Browse repository at this point
Copy the full SHA 32755deView commit details -
% make testacc TESTARGS='-run=TestAccDeployDeploymentGroup_' PKG=deploy ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployDeploymentGroup_ -timeout 360m === RUN TestAccDeployDeploymentGroup_basic === PAUSE TestAccDeployDeploymentGroup_basic === RUN TestAccDeployDeploymentGroup_Basic_tagSet === PAUSE TestAccDeployDeploymentGroup_Basic_tagSet === RUN TestAccDeployDeploymentGroup_onPremiseTag === PAUSE TestAccDeployDeploymentGroup_onPremiseTag === RUN TestAccDeployDeploymentGroup_disappears === PAUSE TestAccDeployDeploymentGroup_disappears === RUN TestAccDeployDeploymentGroup_Disappears_app === PAUSE TestAccDeployDeploymentGroup_Disappears_app === RUN TestAccDeployDeploymentGroup_tags === PAUSE TestAccDeployDeploymentGroup_tags === RUN TestAccDeployDeploymentGroup_Trigger_basic === PAUSE TestAccDeployDeploymentGroup_Trigger_basic === RUN TestAccDeployDeploymentGroup_Trigger_multiple === PAUSE TestAccDeployDeploymentGroup_Trigger_multiple === RUN TestAccDeployDeploymentGroup_AutoRollback_create === PAUSE TestAccDeployDeploymentGroup_AutoRollback_create === RUN TestAccDeployDeploymentGroup_AutoRollback_update === PAUSE TestAccDeployDeploymentGroup_AutoRollback_update === RUN TestAccDeployDeploymentGroup_AutoRollback_delete === PAUSE TestAccDeployDeploymentGroup_AutoRollback_delete === RUN TestAccDeployDeploymentGroup_AutoRollback_disable === PAUSE TestAccDeployDeploymentGroup_AutoRollback_disable === RUN TestAccDeployDeploymentGroup_Alarm_create === PAUSE TestAccDeployDeploymentGroup_Alarm_create === RUN TestAccDeployDeploymentGroup_Alarm_update === PAUSE TestAccDeployDeploymentGroup_Alarm_update === RUN TestAccDeployDeploymentGroup_Alarm_delete === PAUSE TestAccDeployDeploymentGroup_Alarm_delete === RUN TestAccDeployDeploymentGroup_Alarm_disable === PAUSE TestAccDeployDeploymentGroup_Alarm_disable === RUN TestAccDeployDeploymentGroup_DeploymentStyle_default === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_default === RUN TestAccDeployDeploymentGroup_DeploymentStyle_create === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_create === RUN TestAccDeployDeploymentGroup_DeploymentStyle_update === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_update === RUN TestAccDeployDeploymentGroup_DeploymentStyle_delete === PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_delete === RUN TestAccDeployDeploymentGroup_LoadBalancerInfo_create === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_create === RUN TestAccDeployDeploymentGroup_LoadBalancerInfo_update === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_update === RUN TestAccDeployDeploymentGroup_LoadBalancerInfo_delete === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_delete === RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create === RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update === RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete === PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete === RUN TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create === PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create === RUN TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update === PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_create === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_create === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_update === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_update === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_delete === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_delete === RUN TestAccDeployDeploymentGroup_BlueGreenDeployment_complete === PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_complete === RUN TestAccDeployDeploymentGroup_ECS_blueGreen === PAUSE TestAccDeployDeploymentGroup_ECS_blueGreen === RUN TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update === PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update === RUN TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore === PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore === CONT TestAccDeployDeploymentGroup_basic === CONT TestAccDeployDeploymentGroup_DeploymentStyle_update --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (52.12s) === CONT TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update --- PASS: TestAccDeployDeploymentGroup_basic (60.93s) === CONT TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore --- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (32.37s) === CONT TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update --- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (50.29s) === CONT TestAccDeployDeploymentGroup_ECS_blueGreen --- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (334.32s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_complete --- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (32.81s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_delete --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (49.23s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_update --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (49.91s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (45.06s) === CONT TestAccDeployDeploymentGroup_BlueGreenDeployment_create --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (166.66s) === CONT TestAccDeployDeploymentGroup_AutoRollback_update --- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (175.24s) === CONT TestAccDeployDeploymentGroup_DeploymentStyle_create --- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (47.70s) === CONT TestAccDeployDeploymentGroup_DeploymentStyle_default --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (32.36s) === CONT TestAccDeployDeploymentGroup_Alarm_disable --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (32.35s) === CONT TestAccDeployDeploymentGroup_Alarm_delete --- PASS: TestAccDeployDeploymentGroup_Alarm_disable (49.80s) === CONT TestAccDeployDeploymentGroup_Alarm_update --- PASS: TestAccDeployDeploymentGroup_Alarm_delete (50.31s) === CONT TestAccDeployDeploymentGroup_Alarm_create --- PASS: TestAccDeployDeploymentGroup_Alarm_create (33.04s) === CONT TestAccDeployDeploymentGroup_AutoRollback_disable --- PASS: TestAccDeployDeploymentGroup_Alarm_update (49.33s) === CONT TestAccDeployDeploymentGroup_AutoRollback_delete --- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (50.93s) === CONT TestAccDeployDeploymentGroup_tags --- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (51.76s) === CONT TestAccDeployDeploymentGroup_AutoRollback_create --- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (33.85s) === CONT TestAccDeployDeploymentGroup_Trigger_multiple --- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (54.44s) === CONT TestAccDeployDeploymentGroup_Trigger_basic --- PASS: TestAccDeployDeploymentGroup_tags (68.29s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete --- PASS: TestAccDeployDeploymentGroup_Trigger_basic (52.55s) === CONT TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (52.66s) === CONT TestAccDeployDeploymentGroup_disappears --- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (33.66s) === CONT TestAccDeployDeploymentGroup_Disappears_app --- PASS: TestAccDeployDeploymentGroup_disappears (39.55s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfo_update --- PASS: TestAccDeployDeploymentGroup_Disappears_app (30.00s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfo_delete --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (52.07s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (52.45s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfo_create --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (34.64s) === CONT TestAccDeployDeploymentGroup_onPremiseTag --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (52.48s) === CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create --- PASS: TestAccDeployDeploymentGroup_onPremiseTag (34.76s) === CONT TestAccDeployDeploymentGroup_DeploymentStyle_delete --- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (34.20s) === CONT TestAccDeployDeploymentGroup_Basic_tagSet --- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (52.19s) --- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (61.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 923.498s
Configuration menu - View commit details
-
Copy full SHA for eaafed9 - Browse repository at this point
Copy the full SHA eaafed9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e2834a - Browse repository at this point
Copy the full SHA 4e2834aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 244e35b - Browse repository at this point
Copy the full SHA 244e35bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.