Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Adds SSO endpoint override #34302

Merged
merged 9 commits into from
Nov 9, 2023
Merged

provider: Adds SSO endpoint override #34302

merged 9 commits into from
Nov 9, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 7, 2023

Description

Adds parameter endpoints.sso to override the SSO API endpoint.

Depends on release of hashicorp/aws-sdk-go-base#741

Relations

Relates #33952

Output from Acceptance Testing

% TF_ACC=1 go test ./internal/provider/... -v -count=1 -parallel 20 -timeout=0

--- PASS: TestProviderConfig_Authentication_SSO (0.09s)
    --- PASS: TestProviderConfig_Authentication_SSO/shared_configuration_file (0.09s)
--- PASS: TestProviderConfig_Authentication_LegacySSO (0.09s)
    --- PASS: TestProviderConfig_Authentication_LegacySSO/shared_configuration_file (0.09s)
--- PASS: TestExpandEndpoints (0.00s)
--- PASS: TestEndpointMultipleKeys (0.00s)
--- PASS: TestEndpointEnvVarPrecedence (0.00s)
--- PASS: TestInterceptorsWhy (0.00s)
--- PASS: TestValidAssumeRoleDuration (0.00s)
--- PASS: TestTagsResourceInterceptor (0.00s)
--- PASS: TestProvider (0.09s)
--- PASS: TestAccProvider_AssumeRole_empty (126.99s)
--- PASS: TestAccProvider_Region_stsRegion (157.60s)
--- PASS: TestAccProvider_Region_commercial (157.64s)
--- PASS: TestInterceptedHandler (0.00s)
--- PASS: TestAccProvider_Region_c2s (159.78s)
--- PASS: TestAccProvider_Region_sc2s (159.78s)
--- PASS: TestAccProvider_Region_govCloud (161.45s)
--- PASS: TestAccProvider_Region_china (161.54s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_multiple (182.91s)
--- PASS: TestAccProvider_IgnoreTags_emptyBlock (185.74s)
--- PASS: TestAccProvider_DefaultTagsTags_none (186.96s)
--- PASS: TestAccProvider_DefaultAndIgnoreTags_emptyBlocks (188.12s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_none (188.27s)
--- PASS: TestAccProvider_DefaultTags_emptyBlock (189.26s)
--- PASS: TestAccProvider_DefaultTagsTags_one (189.27s)
--- PASS: TestAccProvider_IgnoreTagsKeys_one (189.31s)
--- PASS: TestAccProvider_IgnoreTagsKeys_multiple (189.31s)
--- PASS: TestAccProvider_IgnoreTagsKeys_none (189.32s)
--- PASS: TestAccProvider_endpoints (204.75s)
--- PASS: TestAccProvider_unusualEndpoints (204.77s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_one (93.65s)
--- PASS: TestAccProvider_fipsEndpoint (223.74s)
--- PASS: TestAccProvider_DefaultTagsTags_multiple (68.22s)

Copy link

github-actions bot commented Nov 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Nov 7, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison force-pushed the f-sso-endpoint branch 2 times, most recently from 16b3fdb to cf675b9 Compare November 8, 2023 01:39
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

.changelog/34302.txt Outdated Show resolved Hide resolved
@gdavison gdavison merged commit e61f339 into main Nov 9, 2023
51 checks passed
@gdavison gdavison deleted the f-sso-endpoint branch November 9, 2023 01:11
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 9, 2023
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants