Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appflow_flow: fix perpetual diff on destination_flow_config #34770

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

johnsonaj
Copy link
Contributor

Description

destination_flow_config contains computed/optional fields that can cause a perpetual diff when setting TypeSet. Change to TypeList resolves diff

Relations

Relates #26491

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccAppFlowFlow_" PKG=appflow

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_ -timeout 360m
--- PASS: TestAccAppFlowFlow_taskProperties (213.97s)
--- PASS: TestAccAppFlowFlow_disappears (218.05s)
--- PASS: TestAccAppFlowFlow_basic (219.91s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (298.03s)
--- PASS: TestAccAppFlowFlow_update (299.58s)
--- PASS: TestAccAppFlowFlow_taskUpdate (301.25s)
--- PASS: TestAccAppFlowFlow_tags (367.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	370.713s

Copy link

github-actions bot commented Dec 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/appflow Issues and PRs that pertain to the appflow service. size/XS Managed by automation to categorize the size of a PR. labels Dec 6, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Dec 6, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS="-run=TestAccAppFlowFlow_" PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_ -timeout 360m

--- PASS: TestAccAppFlowFlow_taskProperties (208.40s)
--- PASS: TestAccAppFlowFlow_disappears (213.95s)
--- PASS: TestAccAppFlowFlow_basic (214.54s)
--- PASS: TestAccAppFlowFlow_update (296.27s)
--- PASS: TestAccAppFlowFlow_taskUpdate (296.76s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (297.97s)
--- PASS: TestAccAppFlowFlow_tags (364.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    367.403s

@johnsonaj johnsonaj merged commit 27f495d into main Dec 6, 2023
44 checks passed
@johnsonaj johnsonaj deleted the b-appflow_flow_destination_config_diff branch December 6, 2023 19:16
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 6, 2023
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants