Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show exact AssumeRole error #3490

Closed
wants to merge 1 commit into from

Conversation

redbaron
Copy link

Chained provider conseals real provider error unless verbose flag is
given. When assome_role is specified, only single provider is used,
so it make sense to get credentials straight from it and report
exact error to users.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Feb 22, 2018
@redbaron redbaron force-pushed the lift-assume-role-error branch from 39f272d to 3277410 Compare February 22, 2018 18:48
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Feb 22, 2018
@bflad bflad added the provider Pertains to the provider itself, rather than any interaction with AWS. label Feb 22, 2018
@redbaron
Copy link
Author

@bflad, can it go to 1.11 milestone please?

@bflad
Copy link
Contributor

bflad commented Feb 26, 2018

@redbaron is there a reason this should be prioritized over the other already upvoted pull requests? https://github.com/terraform-providers/terraform-provider-aws/pulls?q=is%3Apr+is%3Aopen+sort%3Areactions-%2B1-desc

You can always create a custom build of the provider if necessary in your environment.

@redbaron
Copy link
Author

redbaron commented Feb 26, 2018

@bflad , sorry I am not familiar with release process and how fixes end up in final releases. I figured this change is small and safe enough to be in next release. I spent quite some time trying to debug failing assume role, so find it useful in case other people end up in the same situation.

If it automatically goes into some release in the future, I am fine with it, as long as it isn't left forgotten :)

@redbaron
Copy link
Author

redbaron commented Jun 5, 2018

any chance it can be merged? :-/ whats the process?

@aeschright aeschright requested a review from a team June 25, 2019 18:48
@aeschright aeschright self-assigned this Oct 21, 2019
@aeschright
Copy link
Contributor

Hi @redbaron! Thanks for your work on this. We ended up splitting this section of the code into a separate package and doing some work on error handling that I think addresses your concerns. Please open a new issue if you run into additional problems, and we'll try to sort out any remaining bugs. Thanks again!

@aeschright aeschright closed this Oct 28, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
@redbaron redbaron deleted the lift-assume-role-error branch March 29, 2020 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants