-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show exact AssumeRole error #3490
Conversation
39f272d
to
3277410
Compare
@bflad, can it go to 1.11 milestone please? |
@redbaron is there a reason this should be prioritized over the other already upvoted pull requests? https://github.com/terraform-providers/terraform-provider-aws/pulls?q=is%3Apr+is%3Aopen+sort%3Areactions-%2B1-desc You can always create a custom build of the provider if necessary in your environment. |
@bflad , sorry I am not familiar with release process and how fixes end up in final releases. I figured this change is small and safe enough to be in next release. I spent quite some time trying to debug failing assume role, so find it useful in case other people end up in the same situation. If it automatically goes into some release in the future, I am fine with it, as long as it isn't left forgotten :) |
any chance it can be merged? :-/ whats the process? |
Hi @redbaron! Thanks for your work on this. We ended up splitting this section of the code into a separate package and doing some work on error handling that I think addresses your concerns. Please open a new issue if you run into additional problems, and we'll try to sort out any remaining bugs. Thanks again! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Chained provider conseals real provider error unless verbose flag is
given. When assome_role is specified, only single provider is used,
so it make sense to get credentials straight from it and report
exact error to users.