Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lb_listener: Fix mutual_authentication mode passthrough #35289

Merged

Conversation

rodrigost23
Copy link
Contributor

Description

This PR changes behaviour of the ignore_client_certificate_expiry attribute in the mutual_authentication block of aws_lb_listener to not set a value when mode is passthrough.

Without this, AWS returns an error (see #34861)

Relations

Closes #34861

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccELBV2Listener_mutualAuthentication.\* PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2Listener_mutualAuthentication.*'  -timeout 360m
=== RUN   TestAccELBV2Listener_mutualAuthentication
=== PAUSE TestAccELBV2Listener_mutualAuthentication
=== RUN   TestAccELBV2Listener_mutualAuthenticationPassthrough
=== PAUSE TestAccELBV2Listener_mutualAuthenticationPassthrough
=== CONT  TestAccELBV2Listener_mutualAuthentication
=== CONT  TestAccELBV2Listener_mutualAuthenticationPassthrough
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (231.79s)
--- PASS: TestAccELBV2Listener_mutualAuthentication (232.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 232.630s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Jan 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 13, 2024
@rodrigost23 rodrigost23 marked this pull request as ready for review January 13, 2024 14:59
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @rodrigost23 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 16, 2024
@ewbankkit ewbankkit self-assigned this Jan 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 17, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2Listener_basic\|TestAccELBV2Listener_mutualAuthentication' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2Listener_basic\|TestAccELBV2Listener_mutualAuthentication -timeout 360m
=== RUN   TestAccELBV2Listener_basic
=== PAUSE TestAccELBV2Listener_basic
=== RUN   TestAccELBV2Listener_mutualAuthentication
=== PAUSE TestAccELBV2Listener_mutualAuthentication
=== RUN   TestAccELBV2Listener_mutualAuthenticationPassthrough
=== PAUSE TestAccELBV2Listener_mutualAuthenticationPassthrough
=== CONT  TestAccELBV2Listener_basic
=== CONT  TestAccELBV2Listener_mutualAuthenticationPassthrough
=== CONT  TestAccELBV2Listener_mutualAuthentication
--- PASS: TestAccELBV2Listener_mutualAuthentication (215.18s)
--- PASS: TestAccELBV2Listener_basic (218.00s)
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (221.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	227.871s

@ewbankkit
Copy link
Contributor

@rodrigost23 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f9ccecb into hashicorp:main Jan 17, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.33.0 milestone Jan 17, 2024
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Jan 18, 2024
Copy link

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@rodrigost23 rodrigost23 deleted the b-aws_lb_listener-mtls-passthrough branch January 21, 2024 00:56
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load Balancer with mutual authentication passthrough does not work
3 participants