-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lb_listener: Fix mutual_authentication mode passthrough #35289
r/aws_lb_listener: Fix mutual_authentication mode passthrough #35289
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @rodrigost23 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccELBV2Listener_basic\|TestAccELBV2Listener_mutualAuthentication' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2Listener_basic\|TestAccELBV2Listener_mutualAuthentication -timeout 360m
=== RUN TestAccELBV2Listener_basic
=== PAUSE TestAccELBV2Listener_basic
=== RUN TestAccELBV2Listener_mutualAuthentication
=== PAUSE TestAccELBV2Listener_mutualAuthentication
=== RUN TestAccELBV2Listener_mutualAuthenticationPassthrough
=== PAUSE TestAccELBV2Listener_mutualAuthenticationPassthrough
=== CONT TestAccELBV2Listener_basic
=== CONT TestAccELBV2Listener_mutualAuthenticationPassthrough
=== CONT TestAccELBV2Listener_mutualAuthentication
--- PASS: TestAccELBV2Listener_mutualAuthentication (215.18s)
--- PASS: TestAccELBV2Listener_basic (218.00s)
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (221.67s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 227.871s
@rodrigost23 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR changes behaviour of the
ignore_client_certificate_expiry
attribute in themutual_authentication
block ofaws_lb_listener
to not set a value whenmode
ispassthrough
.Without this, AWS returns an error (see #34861)
Relations
Closes #34861
References
Output from Acceptance Testing