Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spot price optional to use AWS default #3549

Closed
wants to merge 0 commits into from
Closed

Make spot price optional to use AWS default #3549

wants to merge 0 commits into from

Conversation

YakDriver
Copy link
Member

Fixes #3548

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 27, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 27, 2018
@radeksimko
Copy link
Member

Hi @YakDriver
thanks for the PR.

Do you mind adding an acceptance test which omits this (now optional) argument in the config?

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 6, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 6, 2018
@YakDriver
Copy link
Member Author

YakDriver commented Mar 6, 2018 •
edited
Loading

@radeksimko I added and ran an acceptance test. Without providing a spot price, the SIR created an instance with a max bid of $0.044, which is the current on-demand price for m1.small, as expected per the docs. (Actual price for the instance was $0.0044.)

@YakDriver
Copy link
Member Author

@bflad the "waiting response" tag can be removed from this PR

@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 29, 2018
@YakDriver
Copy link
Member Author

Is it possible to merge this?

@kkopachev
Copy link
Contributor

This needs rebase now.

@ghost ghost added size/M Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 1, 2018
@YakDriver YakDriver closed this May 2, 2018
@YakDriver YakDriver force-pushed the optional-spot-price branch from 9362f1b to 1d5d36a Compare May 2, 2018 13:42
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels May 2, 2018
@YakDriver YakDriver mentioned this pull request May 2, 2018
Merged
@YakDriver
Copy link
Member Author

YakDriver commented May 2, 2018 •
edited
Loading

@kkopachev Due to the time that's passed (conflict/rebasing problems) and need to also update docs & SFR, I closed this PR and opened #4424.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spot price should be optional in aws_spot_instance_request resource
4 participants
@YakDriver @radeksimko @kkopachev @bflad