Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add status arg desc for the aws_iot_domain_configuration resource #35932

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 22, 2024

Description

This PR adds the status argument description to the aws_iot_domain_configuration resource documentation. I've also added links to the two configuration block arguments that were missing.

Relations

Closes #35928

References

Referred to UpdateDomainConfiguration for wording.

Output from Acceptance Testing

n/a

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. labels Feb 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 22, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Feb 26, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b
Copy link
Member

jar-b commented Feb 26, 2024

Thanks for your contribution, @acwwat ! 👍

@jar-b jar-b merged commit 8b43d47 into hashicorp:main Feb 26, 2024
26 checks passed
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 26, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the d-aws_iot_domain_configuration-add_status_arg_desc branch March 1, 2024 05:06
@acwwat acwwat restored the d-aws_iot_domain_configuration-add_status_arg_desc branch March 1, 2024 05:07
@acwwat acwwat deleted the d-aws_iot_domain_configuration-add_status_arg_desc branch March 1, 2024 05:07
Copy link

github-actions bot commented Apr 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: aws_iot_domain_configuration Status argument is not documented
2 participants