-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unhealthy_node_replacement arg for aws_emr_cluster #36523
feat: Add unhealthy_node_replacement arg for aws_emr_cluster #36523
Conversation
Community NoteVoting for Prioritization
For Submitters
|
2093ff7
to
34f9c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEMRCluster_unhealthyNodeReplacement\|TestAccEMRCluster_basic' PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/emr/... -v -count 1 -parallel 20 -run=TestAccEMRCluster_unhealthyNodeReplacement\|TestAccEMRCluster_basic -timeout 360m
=== RUN TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN TestAccEMRCluster_unhealthyNodeReplacement
=== PAUSE TestAccEMRCluster_unhealthyNodeReplacement
=== CONT TestAccEMRCluster_basic
=== CONT TestAccEMRCluster_unhealthyNodeReplacement
--- PASS: TestAccEMRCluster_basic (299.05s)
--- PASS: TestAccEMRCluster_unhealthyNodeReplacement (714.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 726.032s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the new
unhealthy_node_replacement
argument to theaws_emr_cluster
resource.Relations
Closes #36433
References
Referred to RunJobFlow and SetUnhealthyNodeReplacement in the API reference doc.
Output from Acceptance Testing
Note: TestAccEMRCluster_unhealthyNodeReplacement is a new test case.