Add retry mechanism and timeout when reading ecr_repository #3859
Conversation
When creating an ECR repository, creation can be successful but it may not be available right away through DescribeRepositories API request. We add a retry mechanism until the repository appears instead of marking the repository aas not existing. Fixes hashicorp#3849
| `aws_ecr_repository` provides the following [Timeouts](/docs/configuration/resources.html#timeouts) | ||
| configuration options: | ||
|
|
||
| - `read` - (Default `10 minutes`) How long to wait for a repository to be listed. |
There was a problem hiding this comment.
This should probably specifically mention on creation. We also generally prefer to default to 1 minute unless there is some known documentation about eventual consistency taking a certain amount of time.
| if err != nil { | ||
| if d.IsNewResource() && isAWSErr(err, ecr.ErrCodeRepositoryNotFoundException, "") { | ||
| return resource.RetryableError(err) | ||
| } else { |
There was a problem hiding this comment.
Minor nitpick: the else and nesting here are unnecessary
bflad
added
bug
|
@bflad unfortunately, I didn't really think when opening this pull request but we use this commit internally, and I don't want to change the default timeout until we change our use of this resource. I'll close this PR and there is a new PR opened with the changes you requested in #3910 There is no specific AWS documentation telling that an ECR read could take time. They only told us that read requests were more rate limited than write requests. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
When creating an ECR repository, creation can be successful but it may
not be available right away through DescribeRepositories API request. We
add a retry mechanism until the repository appears instead of marking
the repository aas not existing.
Fixes #3849