Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Redshift Serverless resources to AWS SDK v2 #38851

Merged

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Aug 13, 2024

Description

This PR migrates the Redshift Serverless resources to AWS SDKv2.

Relations

Closes #36202
Relates #32976

References

Output from Acceptance Testing

Currently running tests - will update results soon

% make testacc TESTS=TestAccXXX PKG=ec2

...

@DanielRieske DanielRieske requested a review from a team as a code owner August 13, 2024 17:37
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 13, 2024
@ewbankkit ewbankkit added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 13, 2024
@ewbankkit ewbankkit self-assigned this Aug 13, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 13, 2024
…yAccessible` you need a snapshot to be able to update the capacity. During the creation of this `conflictExceptions` occur. We already retry on the deletion for it so it makes sense for update aswell.

make testacc TESTARGS='-run=TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible' PKG=redshiftserverless
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20  -run=TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible -timeout 360m
=== RUN   TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible
=== PAUSE TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible
=== CONT  TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible
--- PASS: TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible (2002.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 2007.594s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRedshiftServerless' PKG=redshiftserverless ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/redshiftserverless/... -v -count 1 -parallel 3  -run=TestAccRedshiftServerless -timeout 720m
=== RUN   TestAccRedshiftServerlessCredentialsDataSource_basic
=== PAUSE TestAccRedshiftServerlessCredentialsDataSource_basic
=== RUN   TestAccRedshiftServerlessCustomDomainAssociation_basic
    custom_domain_association_test.go:27: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccRedshiftServerlessCustomDomainAssociation_basic (0.00s)
=== RUN   TestAccRedshiftServerlessCustomDomainAssociation_disappears
    custom_domain_association_test.go:61: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccRedshiftServerlessCustomDomainAssociation_disappears (0.00s)
=== RUN   TestAccRedshiftServerlessEndpointAccess_basic
=== PAUSE TestAccRedshiftServerlessEndpointAccess_basic
=== RUN   TestAccRedshiftServerlessEndpointAccess_Disappears_workgroup
=== PAUSE TestAccRedshiftServerlessEndpointAccess_Disappears_workgroup
=== RUN   TestAccRedshiftServerlessEndpointAccess_disappears
=== PAUSE TestAccRedshiftServerlessEndpointAccess_disappears
=== RUN   TestAccRedshiftServerlessNamespaceDataSource_basic
=== PAUSE TestAccRedshiftServerlessNamespaceDataSource_basic
=== RUN   TestAccRedshiftServerlessNamespaceDataSource_iamRole
=== PAUSE TestAccRedshiftServerlessNamespaceDataSource_iamRole
=== RUN   TestAccRedshiftServerlessNamespaceDataSource_user
=== PAUSE TestAccRedshiftServerlessNamespaceDataSource_user
=== RUN   TestAccRedshiftServerlessNamespaceDataSource_logExports
=== PAUSE TestAccRedshiftServerlessNamespaceDataSource_logExports
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_defaultIAMRole
=== PAUSE TestAccRedshiftServerlessNamespace_defaultIAMRole
=== RUN   TestAccRedshiftServerlessNamespace_user
=== PAUSE TestAccRedshiftServerlessNamespace_user
=== RUN   TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN   TestAccRedshiftServerlessNamespace_disappears
=== PAUSE TestAccRedshiftServerlessNamespace_disappears
=== RUN   TestAccRedshiftServerlessNamespace_withWorkgroup
=== PAUSE TestAccRedshiftServerlessNamespace_withWorkgroup
=== RUN   TestAccRedshiftServerlessNamespace_manageAdminPassword
=== PAUSE TestAccRedshiftServerlessNamespace_manageAdminPassword
=== RUN   TestAccRedshiftServerlessResourcePolicy_basic
=== PAUSE TestAccRedshiftServerlessResourcePolicy_basic
=== RUN   TestAccRedshiftServerlessResourcePolicy_disappears
=== PAUSE TestAccRedshiftServerlessResourcePolicy_disappears
=== RUN   TestAccRedshiftServerlessSnapshot_basic
=== PAUSE TestAccRedshiftServerlessSnapshot_basic
=== RUN   TestAccRedshiftServerlessSnapshot_disappears
=== PAUSE TestAccRedshiftServerlessSnapshot_disappears
=== RUN   TestAccRedshiftServerlessUsageLimit_basic
=== PAUSE TestAccRedshiftServerlessUsageLimit_basic
=== RUN   TestAccRedshiftServerlessUsageLimit_disappears
=== PAUSE TestAccRedshiftServerlessUsageLimit_disappears
=== RUN   TestAccRedshiftServerlessWorkgroupDataSource_basic
=== PAUSE TestAccRedshiftServerlessWorkgroupDataSource_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_basic
=== PAUSE TestAccRedshiftServerlessWorkgroup_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_configParameters
=== PAUSE TestAccRedshiftServerlessWorkgroup_configParameters
=== RUN   TestAccRedshiftServerlessWorkgroup_tags
=== PAUSE TestAccRedshiftServerlessWorkgroup_tags
=== RUN   TestAccRedshiftServerlessWorkgroup_disappears
=== PAUSE TestAccRedshiftServerlessWorkgroup_disappears
=== RUN   TestAccRedshiftServerlessWorkgroup_port
=== PAUSE TestAccRedshiftServerlessWorkgroup_port
=== CONT  TestAccRedshiftServerlessCredentialsDataSource_basic
=== CONT  TestAccRedshiftServerlessNamespace_manageAdminPassword
=== CONT  TestAccRedshiftServerlessNamespaceDataSource_logExports
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_logExports (10.03s)
=== CONT  TestAccRedshiftServerlessNamespace_withWorkgroup
--- PASS: TestAccRedshiftServerlessNamespace_manageAdminPassword (10.14s)
=== CONT  TestAccRedshiftServerlessNamespace_disappears
--- PASS: TestAccRedshiftServerlessNamespace_disappears (9.21s)
=== CONT  TestAccRedshiftServerlessNamespace_tags
--- PASS: TestAccRedshiftServerlessNamespace_tags (24.24s)
=== CONT  TestAccRedshiftServerlessNamespace_user
--- PASS: TestAccRedshiftServerlessNamespace_user (17.99s)
=== CONT  TestAccRedshiftServerlessNamespace_defaultIAMRole
--- PASS: TestAccRedshiftServerlessNamespace_defaultIAMRole (12.13s)
=== CONT  TestAccRedshiftServerlessNamespace_basic
--- PASS: TestAccRedshiftServerlessNamespace_basic (18.89s)
=== CONT  TestAccRedshiftServerlessNamespaceDataSource_basic
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_basic (9.41s)
=== CONT  TestAccRedshiftServerlessNamespaceDataSource_user
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_user (9.09s)
=== CONT  TestAccRedshiftServerlessNamespaceDataSource_iamRole
--- PASS: TestAccRedshiftServerlessNamespaceDataSource_iamRole (9.98s)
=== CONT  TestAccRedshiftServerlessWorkgroupDataSource_basic
--- PASS: TestAccRedshiftServerlessNamespace_withWorkgroup (301.19s)
=== CONT  TestAccRedshiftServerlessWorkgroup_configParameters
--- PASS: TestAccRedshiftServerlessWorkgroupDataSource_basic (255.83s)
--- PASS: TestAccRedshiftServerlessCredentialsDataSource_basic (388.73s)
=== CONT  TestAccRedshiftServerlessWorkgroup_basic
--- PASS: TestAccRedshiftServerlessWorkgroup_configParameters (310.53s)
=== CONT  TestAccRedshiftServerlessWorkgroup_port
=== CONT  TestAccRedshiftServerlessSnapshot_disappears
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (279.16s)
=== CONT  TestAccRedshiftServerlessUsageLimit_disappears
--- PASS: TestAccRedshiftServerlessWorkgroup_port (227.32s)
=== CONT  TestAccRedshiftServerlessUsageLimit_basic
--- PASS: TestAccRedshiftServerlessUsageLimit_disappears (246.60s)
=== CONT  TestAccRedshiftServerlessResourcePolicy_disappears
    resource_policy_test.go:59: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftServerlessResourcePolicy_disappears (0.00s)
=== CONT  TestAccRedshiftServerlessSnapshot_basic
--- PASS: TestAccRedshiftServerlessSnapshot_disappears (429.03s)
=== CONT  TestAccRedshiftServerlessEndpointAccess_Disappears_workgroup
--- PASS: TestAccRedshiftServerlessUsageLimit_basic (382.60s)
=== CONT  TestAccRedshiftServerlessEndpointAccess_disappears
--- PASS: TestAccRedshiftServerlessSnapshot_basic (396.40s)
=== CONT  TestAccRedshiftServerlessEndpointAccess_basic
--- PASS: TestAccRedshiftServerlessEndpointAccess_Disappears_workgroup (416.41s)
=== CONT  TestAccRedshiftServerlessResourcePolicy_basic
    resource_policy_test.go:29: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftServerlessResourcePolicy_basic (0.00s)
=== CONT  TestAccRedshiftServerlessWorkgroup_disappears
--- PASS: TestAccRedshiftServerlessEndpointAccess_disappears (450.78s)
=== CONT  TestAccRedshiftServerlessWorkgroup_tags
--- PASS: TestAccRedshiftServerlessEndpointAccess_basic (511.97s)
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (251.85s)
--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (469.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	1956.892s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3724def into hashicorp:main Aug 13, 2024
34 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 13, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
@ewbankkit ewbankkit mentioned this pull request Aug 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Redshift Serverless Service
2 participants