Normalize aws_ecs_task_definition healthCheck

internal/service/ecs/container_definitions.go

@@ -59,6 +59,19 @@ func (cd containerDefinitions) reduce(isAWSVPC bool) {
 		if def.Essential == nil {
 			cd[i].Essential = aws.Bool(true)
 		}
+		// Replace nil HealthCheck values with default values. For each property, the default value can be found
+		// in the doc comment for this property.
+		if hc := def.HealthCheck; hc != nil {
+			if hc.Interval == nil {
+				hc.Interval = aws.Int32(30)
+			}
+			if hc.Retries == nil {
+				hc.Retries = aws.Int32(3)
+			}
+			if hc.Timeout == nil {
+				hc.Timeout = aws.Int32(5)
+			}
+		}
 		for j, pm := range def.PortMappings {
 			if pm.Protocol == awstypes.TransportProtocolTcp {
 				cd[i].PortMappings[j].Protocol = ""

internal/service/ecs/container_definitions_test.go

@@ -624,3 +624,76 @@
 		t.Fatal("Expected definitions to be equal.")
 	}
 }
+
+func TestContainerDefinitionsAreEquivalent_healthCheck(t *testing.T) {
+	t.Parallel()
+
+	cfgRepresentation := `
+[
+    {
+        "cpu": 512,
+        "environment": [],
+        "healthCheck": {
+            "command": [
+                "CMD-SHELL",
+                "curl -f http://localhost:8080/health || exit 1"
+            ]
+        },
+        "image": "nginx",
+        "memory": 2048,
+        "name": "nginx",
+        "startTimeout": 10,
+        "logConfiguration": {
+            "logDriver": "awslogs",
+            "options": {
+                "awslogs-group": "foo-bar-e196c99",
+                "awslogs-region": "us-east-1",
+                "awslogs-stream-prefix": "nginx"
+            }
+        }
+    }
+]`
+
+	apiRepresentation := `
+[
+    {
+        "cpu": 512,
+        "environment": [],
+        "essential": true,
+        "healthCheck": {
+            "command": [
+                "CMD-SHELL",
+                "curl -f http://localhost:8080/health || exit 1"
+            ],
+            "interval": 30,
+            "retries": 3,
+            "timeout": 5
+        },
+        "image": "nginx",
+        "logConfiguration": {
+            "logDriver": "awslogs",
+            "options": {
+                "awslogs-group": "foo-bar-e196c99",
+                "awslogs-region": "us-east-1",
+                "awslogs-stream-prefix": "nginx"
+            }
+        },
+        "memory": 2048,
+        "mountPoints": [],
+        "name": "nginx",
+        "portMappings": [],
+        "startTimeout": 10,
+        "systemControls": [],
+        "volumesFrom": []
+    }
+]
+`
+
+	equal, err := containerDefinitionsAreEquivalent(cfgRepresentation, apiRepresentation, false)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !equal {
+		t.Fatal("Expected definitions to be equal.")
+	}
+}