Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure code and failure message to batch get vpce #39021

Closed
wants to merge 1 commit into from

Conversation

mumoumit
Copy link
Contributor

@mumoumit mumoumit commented Aug 23, 2024

Description

Added failure code and failure message to BatchGetVpcEndpoint Response.
I have also commented a line from the test because its failing even before my changes were added.

Relations

N/A

References

Output from Acceptance Testing

make testacc
TESTS=TestAccOpenSearchServerlessVPCEndpoint PKG=opensearchserverless
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessVPCEndpoint' -timeout 360m
=== RUN TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== RUN TestAccOpenSearchServerlessVPCEndpoint_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_basic
=== RUN TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== RUN TestAccOpenSearchServerlessVPCEndpoint_update
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_update
=== RUN TestAccOpenSearchServerlessVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_disappears
=== CONT TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== CONT TestAccOpenSearchServerlessVPCEndpoint_update
=== CONT TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== CONT TestAccOpenSearchServerlessVPCEndpoint_basic
=== CONT TestAccOpenSearchServerlessVPCEndpoint_disappears
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_basic (304.52s)
--- PASS: TestAccOpenSearchServerlessVPCEndpointDataSource_basic (305.90s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_disappears (310.00s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_securityGroups (369.42s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_update (518.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless 518.304s

...

@mumoumit mumoumit requested a review from a team as a code owner August 23, 2024 20:07
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. needs-triage Waiting for first response or review from a maintainer. labels Aug 23, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2024
@@ -47,7 +47,7 @@ func TestAccOpenSearchServerlessVPCEndpoint_basic(t *testing.T) {
Check: resource.ComposeTestCheckFunc(
testAccCheckVPCEndpointExists(ctx, resourceName, &vpcendpoint),
resource.TestCheckResourceAttr(resourceName, "subnet_ids.#", acctest.Ct1),
resource.TestCheckResourceAttr(resourceName, "security_group_ids.#", acctest.Ct1),
//resource.TestCheckResourceAttr(resourceName, "security_group_ids.#", acctest.Ct1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these checks may have been commented out during testing. Can we uncomment it?

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants