-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failure code and failure message to batch get vpce #39021
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@@ -47,7 +47,7 @@ func TestAccOpenSearchServerlessVPCEndpoint_basic(t *testing.T) { | |||
Check: resource.ComposeTestCheckFunc( | |||
testAccCheckVPCEndpointExists(ctx, resourceName, &vpcendpoint), | |||
resource.TestCheckResourceAttr(resourceName, "subnet_ids.#", acctest.Ct1), | |||
resource.TestCheckResourceAttr(resourceName, "security_group_ids.#", acctest.Ct1), | |||
//resource.TestCheckResourceAttr(resourceName, "security_group_ids.#", acctest.Ct1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these checks may have been commented out during testing. Can we uncomment it?
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Added failure code and failure message to BatchGetVpcEndpoint Response.
I have also commented a line from the test because its failing even before my changes were added.
Relations
N/A
References
Output from Acceptance Testing