-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_ec2_transit_gateway_default_route_table_association #39496
New Resource: aws_ec2_transit_gateway_default_route_table_association #39496
Conversation
Community NoteVoting for Prioritization
For Submitters
|
I believe the failing checks are false positives for this change at least. |
abf0743
to
a35e385
Compare
a35e385
to
bf4fcf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^DefaultRouteTableAssociation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/^DefaultRouteTableAssociation_ -timeout 360m
=== RUN TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== RUN TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== RUN TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== CONT TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== CONT TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== CONT TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
--- PASS: TestAccTransitGateway_serial (0.00s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway (176.18s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic (238.99s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears (240.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 245.675s
% make golangci-lint PKG=ec2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3... |
@drewtul Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
New resource
aws_ec2_transit_gateway_default_route_table_association
that allows you to manage setting the default route table for associations on a transit gateway.Relations
Relates #35085 creates one of the two resources required to fix this.
References
Output from Acceptance Testing