Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_ec2_transit_gateway_default_route_table_association #39496

Merged

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Sep 26, 2024

Description

New resource aws_ec2_transit_gateway_default_route_table_association that allows you to manage setting the default route table for associations on a transit gateway.

Relations

Relates #35085 creates one of the two resources required to fix this.

References

Output from Acceptance Testing

% make testacc TESTS='TestAccTransitGateway_serial/DefaultRouteTableAssociation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGateway_serial/DefaultRouteTableAssociation_'  -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic (210.17s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears (210.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        215.675s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/transitgateway Issues and PRs that pertain to the transitgateway service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 26, 2024
@drewtul
Copy link
Contributor Author

drewtul commented Sep 26, 2024

I believe the failing checks are false positives for this change at least.

@drewtul drewtul marked this pull request as ready for review September 26, 2024 11:56
@drewtul drewtul requested a review from a team as a code owner September 26, 2024 11:56
@drewtul drewtul force-pushed the f-tgw-default-route-table-association branch from abf0743 to a35e385 Compare September 26, 2024 14:00
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 27, 2024
@ewbankkit ewbankkit self-assigned this Sep 27, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 27, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^DefaultRouteTableAssociation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/^DefaultRouteTableAssociation_ -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway (176.18s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic (238.99s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears (240.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	245.675s

@ewbankkit
Copy link
Contributor

% make golangci-lint PKG=ec2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
make: golangci-lint Checks / 3 of 3...

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 465d069 into hashicorp:main Sep 27, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 27, 2024
@drewtul drewtul deleted the f-tgw-default-route-table-association branch September 30, 2024 10:31
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/transitgateway Issues and PRs that pertain to the transitgateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants