remove capacity_provider_strategy validation for aws_ecs_service resource

[dejanzele]

Description

When updating capacity_provider_strategy, update should happen in-place and not require recreate.

AWS provider Terraform docs mention a partial solution:

[capacity_provider_strategy](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_service#capacity_provider_strategy)

(Optional) Capacity provider strategies to use for the service. Can be one or more.
These can be updated without destroying and recreating the service only if force_new_deployment = true
and not changing from 0 capacity_provider_strategy blocks to greater than 0, or vice versa.
See below.
Conflicts with launch_type.

The solution isn’t complete as changing base or weight to 0 triggers a recreate, but on AWS Console it can be updated without recreation.

Relations

Relates #37848
Relates #22823
Relates #22408

References

This comment provides a good description why this line should be removed.

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @dejanzele 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[dejanzele]

@justinretzolk what is your opinion?

[justinretzolk]

Hey @dejanzele 👋 Thanks for taking the time to raise this and for checking in here! I can't speak to when this will be prioritized just yet. We base our prioritization on the count of 👍 reactions and a few other considerations (more information: prioritization guide).