Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Remove awssdkpatch #39926

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Tech debt: Remove awssdkpatch #39926

merged 2 commits into from
Oct 29, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Following the effective completion of the migration from AWS SDK for Go v1 to AWS SDK for Go v2. the awssdkpatch tool can be removed.

Relations

Relates #32976.

@ewbankkit ewbankkit requested a review from a team as a code owner October 29, 2024 14:26
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 29, 2024
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. labels Oct 29, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Can also remove the awssdk.patch line from .gitignore

@ewbankkit ewbankkit merged commit 75d9155 into main Oct 29, 2024
46 checks passed
@ewbankkit ewbankkit deleted the td-remove-awssdkpatch branch October 29, 2024 16:59
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 29, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 29, 2024
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. documentation Introduces or discusses updates to documentation. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants