Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_imagebuilder_image_recipe: Fix block_device_mapping.0.ebs.0.delete_on_termination: '' expected type 'bool', got unconvertible type 'string', value: 'true' #39928

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Synch resource and data source types for the block_device_mapping.ebs block.

Relations

Closes #39927.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccImageBuilderImageRecipeDataSource_' PKG=imagebuilder
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImageRecipeDataSource_ -timeout 360m
2024/10/29 11:04:45 Initializing Terraform AWS Provider...
=== RUN   TestAccImageBuilderImageRecipeDataSource_arn
=== PAUSE TestAccImageBuilderImageRecipeDataSource_arn
=== CONT  TestAccImageBuilderImageRecipeDataSource_arn
--- PASS: TestAccImageBuilderImageRecipeDataSource_arn (16.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	22.268s

…lete_on_termination: '' expected type 'bool', got unconvertible type 'string', value: 'true'".
@ewbankkit ewbankkit requested a review from a team as a code owner October 29, 2024 15:11
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 29, 2024
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

% make testacc TESTARGS='-run=TestAccImageBuilderImageRecipeDataSource_' PKG=imagebuilder
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImageRecipeDataSource_ -timeout 360m
2024/10/29 16:30:25 Initializing Terraform AWS Provider...
=== RUN   TestAccImageBuilderImageRecipeDataSource_arn
=== PAUSE TestAccImageBuilderImageRecipeDataSource_arn
=== CONT  TestAccImageBuilderImageRecipeDataSource_arn
--- PASS: TestAccImageBuilderImageRecipeDataSource_arn (20.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	24.798s

@ewbankkit ewbankkit merged commit 63ff69b into main Oct 29, 2024
35 checks passed
@ewbankkit ewbankkit deleted the b-d/aws_imagebuilder_image_recipe branch October 29, 2024 21:16
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 29, 2024
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants