-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_rds_global_cluster: Add endpoint
attribute for DB writer endpoint
#39960
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ppapishe 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
b481224
to
82251e9
Compare
@ppapishe Thanks for your contribution! I cleaned up a few things and will work on getting this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T=TestAccRDSGlobalCluster_basic K=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSGlobalCluster_basic' -timeout 360m
2024/11/14 15:08:06 Initializing Terraform AWS Provider...
=== RUN TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== CONT TestAccRDSGlobalCluster_basic
--- PASS: TestAccRDSGlobalCluster_basic (16.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 20.188s
endpoint
attribute for DB writer endpoint
Description
AWS Started supporting global endpoint for global aurora clusters. This PR is to basically add the new endpoint attribute as a new output attribute.
This basically solves #39862
Relations
Closes #39862
References
Output from Acceptance Testing