r/aws_elasticache_reserved_cache_node: fix start_time schema type
#40090
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/elasticache
The `StartTime` value returned from AWS is a `time.Time` type, so the corresponding Terraform schema should use a custom `timetypes.RFC3339` type for AutoFlex to function properly. This change should prevent `Provider returned invalid result object after apply` errors during creation.
jar-b
force-pushed
the
b-start_time-invalid-result
branch
from
69e2c4a
to
2a09a76
Compare
|
I will test this once v5.76.0 is released. |
|
Awesome - thank you @pshen! |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.76.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I've just tested creating new reserved cache node with v5.76.0. This PR worked perfectly without error in the output. |
|
Thank you for the quick feedback! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
StartTimevalue returned from AWS is atime.Timetype, so the corresponding Terraform schema should use a customtimetypes.RFC3339type for AutoFlex to function properly. This change should preventProvider returned invalid result object after applyerrors during creation.Relations
Closes #40058
Relates #39945
Relates #39451
Relates #29832
Output from Acceptance Testing
We are unable to acceptance test this resource as removal of the reserved cache node requires contacting AWS support. As such, this fix is a best effort implementation and we ask for community feedback on the change. Please link any new bug reports to this PR. Thank you!