Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_launch_configuration: Clean up code #4037

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Conversation

radeksimko
Copy link
Member

This is just a first step in bigger refactoring of the Launch Configuration resource with the aim to unblock #2132

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Apr 4, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 4, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zordrak
Copy link

Zordrak commented May 3, 2018

Per #2973 (comment) I am very concerned that it is no longer possible to specify the user_data attribute of a launch configuration without also providing a value. This prevents user_data from being conditionally specified in a module unless a non-zero default is specified; however changing the default will not only force a recreation of all launch configurations without userdata, but it also removes a perfectly valid AWS configuration from being supported by terraform unless you omit the user_data parameter. Since terraform does not and cannot support the conditional presence of parameters, it completely relies on the ability to detect an empty string as a null value where the parameter is optional in the API call.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants