Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_lb: Remove missing attribute from TestAccAWSLBBackwardsCompatibility #4072

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 5, 2018

Missed this yesterday in #4032 😓 - the attribute should be missing as it is not applicable to application load balancers.

Previously:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBBackwardsCompatibility'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLBBackwardsCompatibility -timeout 120m
=== RUN   TestAccAWSLBBackwardsCompatibility
--- FAIL: TestAccAWSLBBackwardsCompatibility (212.66s)
	testing.go:518: Step 0 error: Check failed: 1 error(s) occurred:

		* Check 9/16 error: aws_alb.lb_test: Attribute 'enable_cross_zone_load_balancing' not found
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	212.707s
make: *** [testacc] Error 1

Now:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBBackwardsCompatibility'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLBBackwardsCompatibility -timeout 120m
=== RUN   TestAccAWSLBBackwardsCompatibility
--- PASS: TestAccAWSLBBackwardsCompatibility (191.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	191.136s

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Apr 5, 2018
@bflad bflad requested a review from appilon April 5, 2018 15:07
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 5, 2018
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the suppress function actually remove the fields from TF state?

@bflad bflad added this to the v1.14.0 milestone Apr 5, 2018
@bflad
Copy link
Contributor Author

bflad commented Apr 5, 2018

Hm, I'm actually not sure. Maybe this actually came from the original PR and I just hadn't noticed it amongst the other "usual" test failures.

@bflad bflad merged commit 6afb81f into master Apr 5, 2018
@bflad bflad deleted the t-aws_lb-missing-attribute branch April 5, 2018 15:28
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants