Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_glue_classifier #4472

Merged
merged 1 commit into from
May 29, 2018
Merged

New Resource: aws_glue_classifier #4472

merged 1 commit into from
May 29, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 7, 2018

Closes #3873

Changes proposed in this pull request:

  • New Resource: aws_glue_classifier

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueClassifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueClassifier -timeout 120m
=== RUN   TestAccAWSGlueClassifier_GrokClassifier
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (19.72s)
=== RUN   TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (19.01s)
=== RUN   TestAccAWSGlueClassifier_JsonClassifier
--- PASS: TestAccAWSGlueClassifier_JsonClassifier (19.38s)
=== RUN   TestAccAWSGlueClassifier_TypeChange
--- PASS: TestAccAWSGlueClassifier_TypeChange (34.42s)
=== RUN   TestAccAWSGlueClassifier_XmlClassifier
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (20.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	113.062s

@bflad bflad added new-resource Introduces a new resource. service/glue Issues and PRs that pertain to the glue service. labels May 7, 2018
@bflad bflad requested a review from a team May 7, 2018 20:52
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label May 7, 2018
@bflad bflad mentioned this pull request May 7, 2018
Closed
@bflad bflad added this to the v1.19.0 milestone May 10, 2018
@bflad bflad modified the milestones: v1.19.0, v1.20.0 May 17, 2018
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label May 23, 2018
@bflad bflad modified the milestones: v1.20.0, v1.21.0 May 23, 2018
@bflad bflad merged commit 9b1674a into master May 29, 2018
@bflad bflad deleted the f-aws_glue_classifier branch May 29, 2018 19:24
bflad added a commit that referenced this pull request May 29, 2018
@bflad
Update CHANGELOG for #4472
13ee7b1
@bflad
Copy link
Contributor Author

bflad commented May 31, 2018

This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@seaspy
Copy link

seaspy commented Jun 19, 2019

May I ask if it will support CSV classifier? It seems to be an option through AWS console.

Thanks!

@bflad
Copy link
Contributor Author

bflad commented Jun 19, 2019

Hi @seaspy, I do not see an open Glue feature request for that functionality at the moment. Please feel free to file a Feature Request with the relevant details so the community or project maintainers can implement this. Thanks.

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Resource for managing AWS Glue Classifiers
3 participants
@bflad @seaspy @paultyng