Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_storagegateway_nfs_file_share #5255

Merged
merged 2 commits into from
Jul 27, 2018
Merged

New Resource: aws_storagegateway_nfs_file_share #5255

merged 2 commits into from
Jul 27, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 19, 2018

Reference: #943

Changes proposed in this pull request:

  • New Resource: aws_storagegateway_nfs_file_share

Output from acceptance testing:

11 tests passed (all tests)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (275.23s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (326.06s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (328.63s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (361.01s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (364.62s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (371.67s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (385.75s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (391.59s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (393.31s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (441.47s)
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (452.08s)

@bflad bflad added new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jul 19, 2018
@bflad bflad requested a review from a team July 19, 2018 16:54
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jul 19, 2018
@bflad bflad force-pushed the f-aws_storagegateway_nfs_file_share branch from bebbc13 to c875593 Compare July 19, 2018 17:40
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jul 19, 2018
@bflad bflad mentioned this pull request Jul 20, 2018
Closed
catsby
catsby reviewed Jul 26, 2018
View reviewed changes
aws/resource_aws_storagegateway_nfs_file_share.go
Squash: aws.String(d.Get("squash").(string)),
}

if v, ok := d.GetOk("kms_key_arn"); ok && v.(string) != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isn't the && v.(string) != "" unnecessary here? The ok from GetOk should denote if the value is the zero value. If the config omits kms_key_arn then ok here will be false, unless I'm not recalling correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the intention of these v.(string) != "" checks with d.GetOk() is for allowing modules to define "" until null is available in Terraform 0.12. If this is unnecessary with Terraform 0.11, we have a lot of code to clean up. 🙁

catsby
catsby approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bflad bflad added this to the v1.30.0 milestone Jul 27, 2018
@bflad bflad merged commit b551dfb into master Jul 27, 2018
@bflad bflad deleted the f-aws_storagegateway_nfs_file_share branch July 27, 2018 14:58
bflad added a commit that referenced this pull request Jul 27, 2018
@bflad
Update CHANGELOG for #5255
105b748
@bflad
Copy link
Contributor Author

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @catsby