Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aws_route_table_association import #5359

Conversation

julienduchesne
Copy link
Contributor

@julienduchesne julienduchesne commented Jul 27, 2018

Fixes #561

Changes proposed in this pull request:

  • Modify the ID of the route table association resource to contain both the route table ID and the subnet id
  • This allows the importation of route table associations using this concatenated ID.
  • Export the association ID in a new attribute association_id

Output from acceptance testing:

TESTARGS='-run=TestAccAWSRouteTableAssociation_basic'  make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSRouteTableAssociation_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRouteTableAssociation_basic
--- PASS: TestAccAWSRouteTableAssociation_basic (96.03s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       96.046s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 27, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 27, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 29, 2018
@ghost ghost added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 5, 2018
@devonhk
Copy link

devonhk commented Apr 1, 2019

Are there any plans to get this merged? Without this functionality I don't see any way of fully importing an existing VPC (except maybe editing my state file directly?).

@nijave
Copy link
Contributor

nijave commented Apr 30, 2019

Is there a reason this isn't being merged?

@sebmargineanu-ob
Copy link

Would be nice to get this merged as I am currently facing the issue with importing RTAs

@nijave
Copy link
Contributor

nijave commented May 1, 2019

Would be nice to get this merged as I am currently facing the issue with importing RTAs

As a work around, you can use something like terraforming (written in Ruby) to export AWS config as security groups then import these into TF state. Next, export TF state and parse for the actual values (state is json) and update your HCL/config. You could also dump with boto3 or any other SDK and generate the config then reconcile. The key is reconciling with tfstate after import.

@aeschright aeschright requested a review from a team June 25, 2019 21:25
@julienduchesne
Copy link
Contributor Author

Seems like this was closed in another PR

@julienduchesne julienduchesne deleted the allow-rtb-association-import branch August 8, 2019 17:14
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow import of aws_route_table_association
5 participants