Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_s3_bucket: Add support for S3 Cross-Region Replication ACL Overwrite #5447

Closed
wants to merge 1 commit into from
Closed

r/aws_s3_bucket: Add support for S3 Cross-Region Replication ACL Overwrite #5447

wants to merge 1 commit into from

Conversation

ewbankkit
Copy link
Contributor

Fixes #2221
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_Replication'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSS3Bucket_Replication -timeout 120m
=== RUN   TestAccAWSS3Bucket_Replication
--- PASS: TestAccAWSS3Bucket_Replication (196.57s)
=== RUN   TestAccAWSS3Bucket_ReplicationWithoutStorageClass
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (59.34s)
=== RUN   TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (33.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	289.578s

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Aug 3, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. labels Aug 4, 2018
@ewbankkit ewbankkit mentioned this pull request Sep 20, 2018
Closed
@ewbankkit
Copy link
Contributor Author

May need some changes if #3577 is merged first.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Sep 20, 2018 •
edited
Loading

Duplicated by #3577.
Not it isn't 😄.
Reopening...

@ewbankkit ewbankkit closed this Sep 20, 2018
@ewbankkit ewbankkit reopened this Sep 20, 2018
@ewbankkit ewbankkit closed this Sep 20, 2018
@ewbankkit ewbankkit reopened this Sep 20, 2018
@ghost ghost added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 10, 2018
@bflad
Copy link
Contributor

bflad commented Oct 10, 2018

Hi @ewbankkit! Thanks for submitting this! It looks like the intent of this functionality was covered by the previous #3577 which was just merged so I'm going to close this, but please do let me know if I missed something. 👍

@bflad bflad closed this Oct 10, 2018
@ewbankkit
Copy link
Contributor Author

Correct, looking at this deeper this was exactly the same functionality as #3577.

@ewbankkit ewbankkit deleted the issue-2221 branch October 10, 2018 20:43
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for S3 Cross-Region Replication ACL Overwrite
2 participants
@ewbankkit @bflad