This addresses the oddity of the configuration

[psteininger]

This addresses the oddity of the configuration in #2796. This simply removes the code that deletes the OAuthToken passed in and arbitrary validation condition looking for GITHUB_TOKEN env variable. This behavior goes against Terraform convention, and was absolutely NOT well documented, it also drove me insane for a few days until I found an off-hand mention and code reference. There was also no rationale provided for why the code should delete what was provided and replace it with the value of arbitrary ENV variable.

A much better way to address this is to improve the schema of the in the project definition to mark OAuthToken as sensitive.

Fixes #2796

Changes proposed in this pull request:

• Remove validation code requiring GITHUB_TOKEN env var
• Remove code that deletes the value provided in the configuration per AWS official documentation

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
I can't get it to run, never worked with Go.
...

[gdavison]

Thanks for the PR, @psteininger. Unfortunately, the AWS API doesn't return the OAuthToken for security reasons, so the change is a bit more involved than not deleting the API response. We've created #14175 to address the issue.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!