Serverless app repo

[gdavison]

Adds AWS Serverless Application Repository applications to the Terraform provider.

Changes proposed in this pull request:

• Adds the resource aws_serverlessrepository_stack
  • Can specify the version
• Adds the data source aws_serverlessrepository_application
  • I'm not sure this is all that useful

Fixes #3981

Needs:

• tags
• documentation
• import functionality

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=ServerlessRepo'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=ServerlessRepo -timeout 120m
=== RUN   TestAccDataSourceAwsServerlessRepositoryApplication_Basic
--- PASS: TestAccDataSourceAwsServerlessRepositoryApplication_Basic (13.93s)
=== RUN   TestAccDataSourceAwsServerlessRepositoryApplication_Versioned
--- PASS: TestAccDataSourceAwsServerlessRepositoryApplication_Versioned (10.72s)
=== RUN   TestAccAwsServerlessRepositoryStack_basic
--- PASS: TestAccAwsServerlessRepositoryStack_basic (69.76s)
=== RUN   TestAccAwsServerlessRepositoryStack_versioned
--- PASS: TestAccAwsServerlessRepositoryStack_versioned (57.98s)
=== RUN   TestAccAwsServerlessRepositoryStack_tagged
--- PASS: TestAccAwsServerlessRepositoryStack_tagged (60.22s)
=== RUN   TestAccAwsServerlessRepositoryStack_versionUpdate
--- PASS: TestAccAwsServerlessRepositoryStack_versionUpdate (113.40s)
=== RUN   TestAccAwsServerlessRepositoryStack_update
--- PASS: TestAccAwsServerlessRepositoryStack_update (98.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	424.206s

[bflad]

Hi @gdavison is this still work in progress? Need any help?

[gdavison]

Hi @bflad. I'm still working on it slowly. I haven't had a chance to do much work on it recently.

[gdavison]

@bflad I've dropped the "[WIP]" :)

[gdavison]

I've put the "[WIP]" label back on. It needed import functionality, and that's causing a number of changes under the hood.

[gdavison]

I ran an informal survey at #3981 (comment), and it's 7-0 for releasing now and backfilling import later.

So I'm removing the [WIP] again, @bflad

[kitsuneninetails]

Is this in limbo, or is someone going to push this forward? It's been almost 3 months since the last update...

[dmccaffery]

... can we move this forward, please :)

[dmccaffery]

@gdavison ... I'm going to whip out a can of whoop pretty soon 💯

I am super happy to help get this over the finish line with code, beer, wine, hugs, whatever is required.

[weslambert]

This is something I would like as well! Thanks!

[chenrui333]

Any update on this?? Love this to be merged soon :)

[gdavison]

Finishing this is needed to complete the acceptance test TestAccAwsSecretsManagerSecretRotation() in #9487

[pacecreative]

+1 For this. :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!