-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data_source/aws_elasticache_replication_group: Output read_endpoint_addresses #6014
data_source/aws_elasticache_replication_group: Output read_endpoint_addresses #6014
Conversation
@@ -23,6 +23,7 @@ func TestAccDataSourceAwsElasticacheReplicationGroup_basic(t *testing.T) { | |||
resource.TestCheckResourceAttr("data.aws_elasticache_replication_group.bar", "automatic_failover_enabled", "true"), | |||
resource.TestCheckResourceAttr("data.aws_elasticache_replication_group.bar", "port", "6379"), | |||
resource.TestCheckResourceAttrSet("data.aws_elasticache_replication_group.bar", "primary_endpoint_address"), | |||
resource.TestCheckResourceAttr("data.aws_elasticache_replication_group.bar", "read_endpoint_addresses", "2"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be read_endpoint_addresses.#
instead if you want to ensure there are two addresses in the list.
Hello there, Any way we can get this PR reviewed? It's open for almost a year and the read-only endpoint is very important for many use-cases. Thank you. |
I'm also curious if this can get merged in. Would be nice to spread read loads across the read replicas. |
Hi @aeschright, can you please assist with this PR? Having the read endpoint address(es) is very important, this PR is 1 year old and we're getting no answer from the reviewers, this is very frustrating. Terraform itself is a great product but issues like this make it very hard to trust the ecosystem. |
Hi everyone! As you know, we're still digging through quite a backlog and onboarding new maintainers takes some time. At first look, I see that the test run results aren't included in the PR description, and that's something we'd want to have before proceeding with the review. If @commixon is no longer able to work on this, someone else could submit a new PR with the changes. Thanks for your patience as we get things moving -- we appreciate the help! |
@aeschright Hi, I've added a similar feature here with tests. Can you take a look? #11313 (comment) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Relates to #5763
Changes proposed in this pull request:
read_endpoint_addresses
in data_source_aws_elasticache_replication_group.go: