Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_source/aws_elasticache_replication_group: Output read_endpoint_addresses #6014

Conversation

commixon
Copy link

Relates to #5763

Changes proposed in this pull request:

  • Adds read_endpoint_addresses in data_source_aws_elasticache_replication_group.go:
			"read_endpoint_addresses": {
				Type:     schema.TypeSet,
				Computed: true,
				Elem:     &schema.Schema{Type: schema.TypeString},
				Set:      schema.HashString,
			},

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 27, 2018
@commixon commixon changed the title [WIP] data_source/aws_elasticache_replication_group: Output read_endpoint_addresses data_source/aws_elasticache_replication_group: Output read_endpoint_addresses Sep 27, 2018
@@ -23,6 +23,7 @@ func TestAccDataSourceAwsElasticacheReplicationGroup_basic(t *testing.T) {
resource.TestCheckResourceAttr("data.aws_elasticache_replication_group.bar", "automatic_failover_enabled", "true"),
resource.TestCheckResourceAttr("data.aws_elasticache_replication_group.bar", "port", "6379"),
resource.TestCheckResourceAttrSet("data.aws_elasticache_replication_group.bar", "primary_endpoint_address"),
resource.TestCheckResourceAttr("data.aws_elasticache_replication_group.bar", "read_endpoint_addresses", "2"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be read_endpoint_addresses.# instead if you want to ensure there are two addresses in the list.

@aeschright aeschright requested a review from a team June 25, 2019 21:32
@RTodorov
Copy link

Hello there,

Any way we can get this PR reviewed? It's open for almost a year and the read-only endpoint is very important for many use-cases.

Thank you.

@RTodorov
Copy link

Hi @nywilken @joestump! Any chance we can make this happen? Thank you!

@ErrantConstruct
Copy link

I'm also curious if this can get merged in. Would be nice to spread read loads across the read replicas.

@RTodorov
Copy link

Hi @aeschright, can you please assist with this PR? Having the read endpoint address(es) is very important, this PR is 1 year old and we're getting no answer from the reviewers, this is very frustrating. Terraform itself is a great product but issues like this make it very hard to trust the ecosystem.
Thank you.

@aeschright
Copy link
Contributor

Hi everyone! As you know, we're still digging through quite a backlog and onboarding new maintainers takes some time. At first look, I see that the test run results aren't included in the PR description, and that's something we'd want to have before proceeding with the review. If @commixon is no longer able to work on this, someone else could submit a new PR with the changes. Thanks for your patience as we get things moving -- we appreciate the help!

@aeschright aeschright added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 12, 2019
@Shivang44
Copy link

@aeschright Hi, I've added a similar feature here with tests. Can you take a look? #11313 (comment)

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 26, 2020
@gdavison
Copy link
Contributor

gdavison commented Jan 5, 2021

Thanks for the PR, @commixon. We've merged #9979, which also supports the resource

@gdavison gdavison closed this Jan 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants