Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_dx_connection: Export bool value of new MTU parameter #6143

Merged
merged 1 commit into from
Oct 14, 2018
Merged

resource/aws_dx_connection: Export bool value of new MTU parameter #6143

merged 1 commit into from
Oct 14, 2018

Conversation

slapula
Copy link
Contributor

@slapula slapula commented Oct 13, 2018

Fixes #6136

Changes proposed in this pull request:

  • Exporting the value of whether or not jumbo frames have been enabled for a given connection

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDxConnection_importBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSDxConnection_importBasic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSDxConnection_importBasic
--- PASS: TestAccAWSDxConnection_importBasic (24.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.383s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. labels Oct 13, 2018
@ewbankkit
Copy link
Contributor

Related:

This was referenced Oct 13, 2018
Merged
Merged
ewbankkit
ewbankkit reviewed Oct 13, 2018
View reviewed changes
aws/resource_aws_dx_connection.go
@@ -43,6 +43,10 @@ func resourceAwsDxConnection() *schema.Resource {
Required: true,
ForceNew: true,
},
"jumbo_frame_capable": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on attribute naming: https://github.com/terraform-providers/terraform-provider-aws/pull/6141/files#r224957129.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go with jumbo_frame_capable to match the API. I'll make this update to the other PRs where they don't match this convention.

@bflad bflad added this to the v1.41.0 milestone Oct 14, 2018
bflad
bflad approved these changes Oct 14, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @slapula! 🚀

@bflad bflad merged commit e1673ae into hashicorp:master Oct 14, 2018
bflad added a commit that referenced this pull request Oct 14, 2018
@bflad
Update CHANGELOG for #6143
e34f6fb
@slapula slapula deleted the dx-connection-mtu branch October 15, 2018 03:20
@bflad
Copy link
Contributor

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit mentioned this pull request Jan 13, 2019
Merged
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.41.0
Development

Successfully merging this pull request may close these issues.

Feature request: Direct Connect support for changing network MTU
3 participants
@slapula @ewbankkit @bflad