-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/provider: Fix unparam Linting Issues and Enable in TravisCI Testing #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
provider
Pertains to the provider itself, rather than any interaction with AWS.
labels
Nov 2, 2018
ghost
added
size/XL
Managed by automation to categorize the size of a PR.
service/apigateway
Issues and PRs that pertain to the apigateway service.
service/autoscaling
Issues and PRs that pertain to the autoscaling service.
service/batch
Issues and PRs that pertain to the batch service.
service/cloudwatchevents
service/ec2
Issues and PRs that pertain to the ec2 service.
service/ecs
Issues and PRs that pertain to the ecs service.
service/elasticache
Issues and PRs that pertain to the elasticache service.
service/elb
Issues and PRs that pertain to the elb service.
service/emr
Issues and PRs that pertain to the emr service.
service/iam
Issues and PRs that pertain to the iam service.
service/kms
Issues and PRs that pertain to the kms service.
service/opsworks
Issues and PRs that pertain to the opsworks service.
service/redshift
Issues and PRs that pertain to the redshift service.
service/ses
Issues and PRs that pertain to the ses service.
labels
Nov 2, 2018
bflad
commented
Nov 2, 2018
…N parser if non-empty string
tombuildsstuff
approved these changes
Nov 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
provider
Pertains to the provider itself, rather than any interaction with AWS.
service/apigateway
Issues and PRs that pertain to the apigateway service.
service/autoscaling
Issues and PRs that pertain to the autoscaling service.
service/batch
Issues and PRs that pertain to the batch service.
service/ec2
Issues and PRs that pertain to the ec2 service.
service/ecs
Issues and PRs that pertain to the ecs service.
service/elasticache
Issues and PRs that pertain to the elasticache service.
service/elb
Issues and PRs that pertain to the elb service.
service/emr
Issues and PRs that pertain to the emr service.
service/iam
Issues and PRs that pertain to the iam service.
service/kms
Issues and PRs that pertain to the kms service.
service/opsworks
Issues and PRs that pertain to the opsworks service.
service/redshift
Issues and PRs that pertain to the redshift service.
service/ses
Issues and PRs that pertain to the ses service.
size/XL
Managed by automation to categorize the size of a PR.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6336
Reference #5983
Changes proposed in this pull request:
unparam
linting issues such as unused parametersunparam
that will eventually be migrated into their own packages (ones that should keep their same function signature)getStringPtrList()
which is part of Refactor Out getStringPtr() and getStringPtrList() #5983 👍Output from acceptance testing: