Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Gateway API Key data source #6449

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

gthole
Copy link
Contributor

@gthole gthole commented Nov 13, 2018

Changes proposed in this pull request:

  • Add a data source for API Gateway API Keys - When deploying a micro-service, if it has a dependency on some other micro-service, it will need to have an API Gateway API Key made available for injecting into configs (for example, Lambda environment variables). Creating a data source allows us to fetch the appropriate API Key without having to duplicate it or script it somehow.

Output from acceptance testing:

$  make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsApiGatewayApiKey'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccDataSourceAwsApiGatewayApiKey -timeout 120m
=== RUN   TestAccDataSourceAwsApiGatewayApiKey
=== PAUSE TestAccDataSourceAwsApiGatewayApiKey
=== CONT  TestAccDataSourceAwsApiGatewayApiKey
--- PASS: TestAccDataSourceAwsApiGatewayApiKey (185.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       185.603s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 13, 2018
@bflad bflad added the new-data-source Introduces a new data source. label Nov 13, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @gthole! This is a great start. A few little things then we can get this initial data source in. 😄

aws/data_source_aws_api_gateway_api_key_test.go Outdated Show resolved Hide resolved
website/docs/d/api_gateway_api_key.html.markdown Outdated Show resolved Hide resolved
website/docs/d/api_gateway_api_key.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 14, 2018
@gthole
Copy link
Contributor Author

gthole commented Nov 19, 2018

Ping @bflad - this is all set to go with your review comments addressed!

@bflad bflad added this to the v1.46.0 milestone Nov 19, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @gthole 🚀

--- PASS: TestAccDataSourceAwsApiGatewayApiKey (5.12s)

@bflad bflad merged commit cca4fbb into hashicorp:master Nov 20, 2018
bflad added a commit that referenced this pull request Nov 20, 2018
@bflad
Copy link
Contributor

bflad commented Nov 20, 2018

This has been released in version 1.46.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants