Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_autoscaling_group: Mixed Instances Policy support #6465

Merged
merged 2 commits into from
Nov 15, 2018
Merged

resource/aws_autoscaling_group: Mixed Instances Policy support #6465

merged 2 commits into from
Nov 15, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 15, 2018 •
edited
Loading

Includes AWS Go SDK v1.15.76 update.

Changes proposed in this pull request:

  • resource/aws_autoscaling_group: Add mixed_instances_policy configuration block

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (120.37s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (298.01s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (57.81s)
--- PASS: TestAccAWSAutoScalingGroup_basic (248.75s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (91.95s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (57.67s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (178.03s)
--- PASS: TestAccAWSAutoScalingGroup_importBasic (294.21s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (304.69s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (88.16s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (75.13s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (152.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (51.39s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (75.82s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (109.84s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (73.55s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (71.66s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (84.97s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (119.46s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (99.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (83.50s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (87.43s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (88.00s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (116.35s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (280.81s)
--- PASS: TestAccAWSAutoScalingGroup_tags (239.45s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (153.52s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (85.95s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (519.23s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (85.05s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (193.90s)

bflad added 2 commits November 14, 2018 19:31
@bflad
deps: aws/aws-sdk-go@v1.15.76
d673b60 
Updated via: govendor fetch github.com/aws/aws-sdk-go/...@v1.15.76
@bflad
resource/aws_autoscaling_group: Mixed Instances Policy support
9b4e6cb
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Nov 15, 2018
@bflad bflad requested a review from a team November 15, 2018 00:56
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 15, 2018
@bflad bflad added this to the v1.45.0 milestone Nov 15, 2018
@bflad
Copy link
Contributor Author

bflad commented Nov 15, 2018

Previously reviewed -- self-merging after TravisCI passes.

@bflad bflad merged commit a9c8508 into master Nov 15, 2018
@bflad bflad deleted the f-aws_autoscaling_group-mixed_instances_policy branch November 15, 2018 01:06
bflad added a commit that referenced this pull request Nov 15, 2018
@bflad
Update CHANGELOG for #6465
d562a39
@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.45.0
Development

Successfully merging this pull request may close these issues.
1 participant
@bflad