-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecs-Add support for ECS IPC Mode/PID Mode #6515
Conversation
4c8a633
to
b1a8adf
Compare
b1a8adf
to
03ced11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this, @sunilkumarmohanty. Three minor little things then this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much @sunilkumarmohanty 🚀
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (5.39s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (5.59s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (5.77s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (5.76s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (5.75s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (5.74s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (16.33s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (19.62s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (20.06s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (20.41s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (20.53s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (20.73s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (20.62s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (20.86s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (21.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (34.14s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (34.41s)
This has been released in version 1.46.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #6511
Changes proposed in this pull request:
Output from acceptance testing: