Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] r/aws_security_hub: New resources #6744

Closed
wants to merge 17 commits into from
Closed

[WIP] r/aws_security_hub: New resources #6744

wants to merge 17 commits into from

Conversation

gazoakley
Copy link
Contributor

@gazoakley gazoakley commented Dec 6, 2018 •
edited
Loading

Fixes #6674

Changes proposed in this pull request:

  • New Resource: aws_securityhub_account

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSecurityHub'

...

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 6, 2018
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Dec 7, 2018
@bflad bflad added service/securityhub Issues and PRs that pertain to the securityhub service. new-resource Introduces a new resource. labels Dec 7, 2018
@gazoakley
Copy link
Contributor Author

I'm going to close this - will create individual PRs for each resource to help make reviews simpler.

@gazoakley gazoakley closed this Dec 13, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/securityhub Issues and PRs that pertain to the securityhub service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Security Hub
2 participants
@gazoakley @bflad