Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws-securityhub: Add aws_securityhub_account resource #6839

Merged
merged 2 commits into from
Dec 13, 2018
Merged

r/aws-securityhub: Add aws_securityhub_account resource #6839

merged 2 commits into from
Dec 13, 2018

Conversation

gazoakley
Copy link
Contributor

@gazoakley gazoakley commented Dec 13, 2018 •
edited
Loading

Partly addresses #6674

Changes proposed in this pull request:

  • New Resource: aws_securityhub_account

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSecurityHub'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSecurityHub -timeout 120m
=== RUN   TestAccAWSSecurityHub
=== RUN   TestAccAWSSecurityHub/Account
=== RUN   TestAccAWSSecurityHub/Account/basic
--- PASS: TestAccAWSSecurityHub (74.25s)
    --- PASS: TestAccAWSSecurityHub/Account (74.25s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (74.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	74.287s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 13, 2018
@bflad bflad added new-resource Introduces a new resource. service/securityhub Issues and PRs that pertain to the securityhub service. labels Dec 13, 2018
bflad
bflad reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little items then this should be good to go, thanks @gazoakley!

aws/resource_aws_securityhub_account.go Outdated Show resolved Hide resolved
aws/resource_aws_securityhub_account_test.go Outdated Show resolved Hide resolved
website/docs/r/securityhub_account.markdown Outdated Show resolved Hide resolved
website/docs/r/securityhub_account.markdown Outdated Show resolved Hide resolved
website/docs/r/securityhub_account.markdown Outdated Show resolved Hide resolved
website/docs/r/securityhub_account.markdown Outdated Show resolved Hide resolved
website/docs/r/securityhub_account.markdown Outdated Show resolved Hide resolved
website/docs/r/securityhub_account.markdown Outdated Show resolved Hide resolved
@gazoakley
Copy link
Contributor Author

@bflad: Updated with your comments. Just curious as to why the test changes? 😃

@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

Answered inline above

@bflad bflad added this to the v1.52.0 milestone Dec 13, 2018
bflad
bflad approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gazoakley! 🚀

--- PASS: TestAccAWSSecurityHub (10.83s)
    --- PASS: TestAccAWSSecurityHub/Account (10.83s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (10.83s)

@bflad bflad merged commit fa9ae9a into hashicorp:master Dec 13, 2018
bflad added a commit that referenced this pull request Dec 13, 2018
@bflad
Update CHANGELOG for #6839
dd73837
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
@gazoakley gazoakley deleted the f-security-hub-account branch April 7, 2020 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/securityhub Issues and PRs that pertain to the securityhub service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gazoakley @bflad