Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/separate route table association import #7282

Closed
wants to merge 2 commits into from
Closed

Feature/separate route table association import #7282

wants to merge 2 commits into from

Conversation

snakeb1t
Copy link
Contributor

@snakeb1t snakeb1t commented Jan 24, 2019 •
edited
Loading

Changes proposed in this pull request:

  • Enable importing of AWS route table associations
    • Without the problems surrounding the importing of those associations en masse when a route table is imported

Output from acceptance testing:

ptittle@ptittle98-mac ~/src/go/src/github.com/terraform-providers/terraform-provider-aws (feature/separate_route_table_association_import) $ make testacc TESTARGS='-run=TestAccAWSRouteTableAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRouteTableAssociation -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSRouteTableAssociation_basic
=== PAUSE TestAccAWSRouteTableAssociation_basic
=== CONT  TestAccAWSRouteTableAssociation_basic
--- PASS: TestAccAWSRouteTableAssociation_basic (64.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.027s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 24, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 25, 2019
@pit pit mentioned this pull request Mar 12, 2019
Closed
@aeschright aeschright requested a review from a team June 25, 2019 22:09
@bflad
Copy link
Contributor

bflad commented Mar 18, 2020

Support for aws_route_table_association resource import was handled via #6999 and previously released in version 2.22.0 of the Terraform AWS Provider. 👍

@bflad bflad closed this Mar 18, 2020
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snakeb1t @bflad