Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7501 Unable to create api_gateway_domain using aws_route53_zone.name #7588

Closed
wants to merge 2 commits into from

Conversation

saravanan30erd
Copy link
Contributor

Fixes #7501

Changes proposed in this pull request:

  • Change 1
    removing Trailing period in domain_name input

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayDomainName_verifyDomainName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGatewayDomainName_verifyDomainName -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_verifyDomainName
=== PAUSE TestAccAWSAPIGatewayDomainName_verifyDomainName
=== CONT  TestAccAWSAPIGatewayDomainName_verifyDomainName
--- PASS: TestAccAWSAPIGatewayDomainName_verifyDomainName (31.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws
...

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 16, 2019
@aeschright aeschright requested a review from a team June 26, 2019 00:48
@bflad
Copy link
Contributor

bflad commented Jun 29, 2020

Hi @saravanan30erd 👋 Thank you for submitting this. We are anticipating the removal of all these trailing period workarounds via #13510 in the next major version of the Terraform AWS Provider. We're scheduling to begin work on that next week so we are going to close this in anticipation of those breaking changes.

@bflad bflad closed this Jun 29, 2020
@ghost
Copy link

ghost commented Jul 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create api_gateway_domain using aws_route53_zone.name
2 participants