-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: support for opsworks for chef automate #7817
Closed
Closed
Commits on Mar 5, 2019
-
It's missing a bunch of stuff, for sure, like parameters, tests, docs, etc, and I haven't actually run it against aws, but I have what I think is all of the boilerplate required, so it's a start
Configuration menu - View commit details
-
Copy full SHA for 05af368 - Browse repository at this point
Copy the full SHA 05af368View commit details -
I grabbed all of these from the API docs: https://docs.aws.amazon.com/sdk-for-go/api/service/opsworkscm/#CreateServerInput It's still not entirely there, and I'll need to document the instance/service profile ARN stuff, and the security groups since I think the security groups need to be made outside and not automanaged by the server resource on AWS's side
Configuration menu - View commit details
-
Copy full SHA for d64c822 - Browse repository at this point
Copy the full SHA d64c822View commit details -
send the parameters to the api
everything is there but the EngineAttributes bit and validation. also debating still on whether some of those required params should be optional. I'd like them to be required, but I'll have to ask upstream their thoughts
Configuration menu - View commit details
-
Copy full SHA for a4b72ae - Browse repository at this point
Copy the full SHA a4b72aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cc6329 - Browse repository at this point
Copy the full SHA 3cc6329View commit details -
They already are required because of the way I made the Create function, so while it's still an open question whether or not they should actually be required required, I at least want to make it consistent at the moment
Configuration menu - View commit details
-
Copy full SHA for cac53cb - Browse repository at this point
Copy the full SHA cac53cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdf44d2 - Browse repository at this point
Copy the full SHA cdf44d2View commit details
Commits on Mar 6, 2019
-
I think this is the baseline requirements for setting up the opsworks_chef instance. It's ... verbose. But this is also a fairly complex thing to be creating, so that's kinda to be expected, methinks.
Configuration menu - View commit details
-
Copy full SHA for 2641e0d - Browse repository at this point
Copy the full SHA 2641e0dView commit details -
per discussion in the PR, I think ForceNew here is probably a bad idea because it will almost certainly destroy any node associations, but at least it won't silently do nothing :)
Configuration menu - View commit details
-
Copy full SHA for 0cad028 - Browse repository at this point
Copy the full SHA 0cad028View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94b271c - Browse repository at this point
Copy the full SHA 94b271cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6603197 - Browse repository at this point
Copy the full SHA 6603197View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec3a977 - Browse repository at this point
Copy the full SHA ec3a977View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0cce4d - Browse repository at this point
Copy the full SHA a0cce4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61fb889 - Browse repository at this point
Copy the full SHA 61fb889View commit details -
Configuration menu - View commit details
-
Copy full SHA for 206e2f9 - Browse repository at this point
Copy the full SHA 206e2f9View commit details
Commits on Mar 7, 2019
-
some fixes for the actual test code
since this doesn't seem to be running yet (I think this only runs in acceptance tests?) it doesn't explode, but I'm testing something like it elsewhere
Configuration menu - View commit details
-
Copy full SHA for 71fa201 - Browse repository at this point
Copy the full SHA 71fa201View commit details
Commits on Mar 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 96f3661 - Browse repository at this point
Copy the full SHA 96f3661View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.