Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for resource tags for Athena Service #8136

Closed
wants to merge 1 commit into from
Closed

Add support for resource tags for Athena Service #8136

wants to merge 1 commit into from
+213 −0

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7667

Changes proposed in this pull request:

  • Add support for resource tags for Athena Service

Output from acceptance testing:

No tests.

@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 31, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-resource-tags-for-athena-service branch from e8bd44d to a1d5fa4 Compare April 1, 2019 00:57
@ewbankkit ewbankkit mentioned this pull request Apr 2, 2019
Closed
@aeschright aeschright requested a review from a team June 26, 2019 00:54
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service. labels Jul 9, 2019
@bflad bflad mentioned this pull request Jul 9, 2019
Closed
@bflad bflad self-assigned this Jul 9, 2019
@bflad bflad mentioned this pull request Jul 10, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Jul 10, 2019

Followup PR which includes the commit here is available at: #9290

Please follow that pull request for further updates and thank you for starting this, @kterada0509!

@bflad bflad closed this Jul 10, 2019
@bflad bflad added this to the v2.19.0 milestone Jul 11, 2019
@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

#9290 has been merged and will release with version 2.19.0 of the Terraform AWS Provider, likely later today. 👍

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
@teraken0509 teraken0509 deleted the feature/add-support-resource-tags-for-athena-service branch March 5, 2020 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

r/aws_athena_workgroup: Add support for resource tags
2 participants
@teraken0509 @bflad