Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource xray sampling rules #8535
Resource xray sampling rules #8535
Changes from 16 commits
b9a4d50
ff1743d
aada9c2
8423511
09f935b
fa109ff
cea2f4c
024f274
cd6de39
8c8e0e8
e5f9b47
b549d8d
c909e8b
53286d8
d728cdf
0d8dfea
6d49669
75ba18a
7810470
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bflad Do you think this would require a custom validator as the validation helper does not support anything along the lines of
FloatBetween
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears there are two upstream PRs for adding
FloatBetween
to thehelper/validation
package upstream:I cannot imagine there is a specific reason why one of these is not merged, so I will followup with those maintainers to make sure the new validation function gets in. We are likely pulling in a newer version of the upstream dependency later this week anyways as part of some Terraform 0.12 work, so this problem might resolve itself shortly. I would suggest omitting any changes in this regard for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two notes:
Elem
declaration to delineate the underlying map value type, as it likely will when a future version of the Terraform Provider SDK supports multiple map value types. I don't see an explicitElem
section in the Extending Terraform documentation section on schemas so I will make a note to ensure this gets added.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the
Elem
part - However,ValidateFunc: validation.StringLenBetween(1, 32),
on the TypeMap level causes this:Input:
Output:
testing.go:568: Step 0 error: config is invalid: expected type of attributes to be string