Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appautoscaling_scheduled_action: Fix bugs #8777

Merged
merged 8 commits into from
Mar 8, 2021
Merged

r/aws_appautoscaling_scheduled_action: Fix bugs #8777

merged 8 commits into from
Mar 8, 2021

Commits on May 25, 2019

  1. Do not default max_capacity and min_capacity to 0. Allow them to be l… 

    …eft undefined so that they can be used individually.
    @stefansundin
    stefansundin committed May 25, 2019
    Configuration menu
    Copy the full SHA
    c6cfae0 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Merge branch 'master' into appautoscaling_scheduled_action-capacity-fix

    @stefansundin
    stefansundin committed May 28, 2019
    Configuration menu
    Copy the full SHA
    1ded7ff View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Use ResourceId when reading the scheduled action, because you can cre… 

    …ate multiple scheduled actions with the same name if they target different resources. For example, you can have multiple scheduled actions named "scale-down" that target different Aurora clusters.
    @stefansundin
    stefansundin committed May 30, 2019
    Configuration menu
    Copy the full SHA
    2c09217 View commit details
    Browse the repository at this point in the history

  2. Set more attributes than just the arn when reading the resource. This… 

    … allows us to update these attributes.
    @stefansundin
    stefansundin committed May 30, 2019
    Configuration menu
    Copy the full SHA
    20825f3 View commit details
    Browse the repository at this point in the history

  3. It is not necessary to delete and recreate the scheduled action when … 

    …updating these attributes, we can just put and it will overwrite the existing resource.
    @stefansundin
    stefansundin committed May 30, 2019
    Configuration menu
    Copy the full SHA
    ac9de91 View commit details
    Browse the repository at this point in the history

  4. Ugh.. use TypeString to allow unspecified value. Based on similar cod… 

    …e in resource_aws_launch_template.go.
    @stefansundin
    stefansundin committed May 30, 2019
    Configuration menu
    Copy the full SHA
    0ca43a8 View commit details
    Browse the repository at this point in the history

  5. Update test to also update the scheduled action.

    @stefansundin
    stefansundin committed May 30, 2019
    Configuration menu
    Copy the full SHA
    403c157 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary variable.

    @stefansundin
    stefansundin committed May 30, 2019
    Configuration menu
    Copy the full SHA
    a0d686e View commit details
    Browse the repository at this point in the history