New Resource: aws_servicequotas_service_quota #9121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, AWS doesn't give all key types. Addresses #7553
The AWS API returns ******** for the ADDomainJoinUser attribute, the same as for ADDomainJoinPassword, CrossRealmTrustPrincipalPassword, and KdcAdminPassword. This causes a terraform plan to always attempt to rebuild the cluster since the ad_domain_join_user attribute is seen as changing from ******** to what is specified and desired in the plan. This now configures EMR to not retrieve this attribute from the AWS APIs so that it doesn't always attempt to rebuild the cluster.
Co-Authored-By: Brian Flad <bflad417@gmail.com>
I recieved the error "The argument "host" is required, but no definition was found." until I added this. This example should be updated. ``` Terraform v0.12.1 + provider.aws v2.14.0 ```
…ault data sources
The above parameter is required to deploy an msk cluster. See https://github.com/terraform-providers/terraform-provider-aws/pull/8635/files for further details
Add missing provider on attachment accepter.
This closes #9043, a question about documentation for customized_metrics_specification. Confirmed the AWS API is available. Documentation update includes link to API documentation.
Co-Authored-By: Brian Flad <bflad417@gmail.com>
… Storage Autoscaling) Reference: #9076 Output from acceptance testing (test failures present in master): ``` --- FAIL: TestAccAWSDBInstance_optionGroup (9.60s) --- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (407.82s) --- PASS: TestAccAWSDBInstance_kmsKey (447.28s) --- PASS: TestAccAWSDBInstance_iamAuth (468.51s) --- PASS: TestAccAWSDBInstance_basic (469.82s) --- PASS: TestAccAWSDBInstance_generatedName (509.47s) --- PASS: TestAccAWSDBInstance_namePrefix (509.57s) --- PASS: TestAccAWSDBInstance_DeletionProtection (534.93s) --- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (554.00s) --- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (640.05s) --- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (839.74s) --- PASS: TestAccAWSDBInstance_subnetGroup (864.75s) --- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (975.11s) --- FAIL: TestAccAWSDBInstance_S3Import (661.46s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1464.99s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1520.22s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1536.83s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1586.30s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1635.73s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1697.74s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1263.54s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1349.56s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1940.63s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1949.99s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1519.48s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1475.69s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1389.89s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1623.10s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1233.00s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1245.29s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1661.06s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1285.34s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2146.49s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1083.14s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1149.70s) --- PASS: TestAccAWSDBInstance_portUpdate (570.32s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1234.86s) --- PASS: TestAccAWSDBInstance_enhancedMonitoring (670.62s) --- PASS: TestAccAWSDBInstance_separate_iops_update (632.53s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1335.83s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1225.51s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1295.29s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1799.33s) --- PASS: TestAccAWSDBInstance_MinorVersion (343.49s) --- PASS: TestAccAWSDBInstance_ec2Classic (395.42s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1173.81s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1094.16s) --- PASS: TestAccAWSDBInstance_diffSuppressInitialState (443.64s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1223.46s) --- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (511.70s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1284.52s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1196.15s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (495.06s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1638.76s) --- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (759.27s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (686.93s) --- PASS: TestAccAWSDBInstance_MSSQL_TZ (1926.59s) --- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1864.61s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1527.89s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1632.72s) --- PASS: TestAccAWSDBInstance_MSSQL_Domain (3296.64s) --- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (3228.09s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (4095.19s) ```
… RestoreDBInstancesFromS3 for now
Add acctest for when resource disappears
Not retrieve EMR AD Domain Join User from AWS API
Fix casing when targeting InstanceIds to avoid the following error: ``` Error: ValidationException: Targets must be specified in one of the following formats: 1) 1 target with "Key=InstanceIds" and "Values=" a list of up to 50 instance IDs, or 2) Up to 5 targets, each of which can be either "Key=tag:<key>,Values=<tag_values>" or "Key=tag-key,Values=<tag_keys>", and each with up to 5 unique tag keys/values. ```
…ote that they cannot perform drift detection The API does not return the actual values for these attributes, so we can only suggest ignore_changes when importing.
Update rds_global_cluster.html.markdown
Fix doc casing `sm_maintenance_window` when targeting InstanceIds
…a-sources New Data Sources: aws_servicequotas_service and aws_servicequotas_service_quota
Reference: #9118 Output from acceptance testing (requesting increase of t3.nano and t3.micro limits in testing account): ``` export SERVICEQUOTAS_INCREASE_ON_CREATE_QUOTA_CODE=L-55EB784E export SERVICEQUOTAS_INCREASE_ON_CREATE_SERVICE_CODE=ec2 export SERVICEQUOTAS_INCREASE_ON_CREATE_VALUE=25 export SERVICEQUOTAS_INCREASE_ON_UPDATE_QUOTA_CODE=L-0F0ED007 export SERVICEQUOTAS_INCREASE_ON_UPDATE_SERVICE_CODE=ec2 export SERVICEQUOTAS_INCREASE_ON_UPDATE_VALUE=25 --- PASS: TestAccAwsServiceQuotasServiceQuota_basic (13.83s) --- PASS: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnCreate (12.52s) --- PASS: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnUpdate (20.00s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAwsServiceQuotasServiceQuota_basic (2.51s) resource_aws_servicequotas_service_quota_test.go:138: skipping acceptance testing: RequestError: send request failed caused by: Post https://servicequotas.us-gov-west-1.amazonaws.com/: dial tcp: lookup servicequotas.us-gov-west-1.amazonaws.com: no such host ```
bflad
force-pushed
the
f-aws_servicequotas_service_quota-resource
branch
from
6ccd9e9
to
85e582b
Compare
Output from acceptance testing in AWS GovCloud (US):
```
--- SKIP: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (2.18s)
resource_aws_servicequotas_service_quota_test.go:146: skipping acceptance testing: RequestError: send request failed
caused by: Post https://servicequotas.us-gov-west-1.amazonaws.com/: dial tcp: lookup servicequotas.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsServiceQuotasServiceDataSource_ServiceName (2.18s)
resource_aws_servicequotas_service_quota_test.go:146: skipping acceptance testing: RequestError: send request failed
caused by: Post https://servicequotas.us-gov-west-1.amazonaws.com/: dial tcp: lookup servicequotas.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (2.18s)
resource_aws_servicequotas_service_quota_test.go:146: skipping acceptance testing: RequestError: send request failed
caused by: Post https://servicequotas.us-gov-west-1.amazonaws.com/: dial tcp: lookup servicequotas.us-gov-west-1.amazonaws.com: no such host
```
ghost
added
size/XXL
…ness, not output again
|
Arg, terrible rebase. Replacing with fresh pull request: #9192 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9118
Release note for CHANGELOG:
Output from acceptance testing (requesting increase of t3.nano and t3.micro limits in testing account):
Output from acceptance testing in AWS GovCloud (US):