Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_waf_web_acl: Add WAF Web ACL lookup datasource #9320

Merged
merged 5 commits into from
Jul 18, 2019
Merged

d/aws_waf_web_acl: Add WAF Web ACL lookup datasource #9320

merged 5 commits into from
Jul 18, 2019

Conversation

robh007
Copy link
Contributor

@robh007 robh007 commented Jul 12, 2019 •
edited by ryndaniels
Loading

AWS WAF Web ACL lookup datasource

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #2654

Release note for CHANGELOG:

** New datasource ** `aws_waf_web_acl`

Output from acceptance testing:

$ make testacc ./aws TESTARGS='-run=TestAccDataSourceAwsWafWebAcl'
--- PASS: TestAccDataSourceAwsWafWebAcl_Basic (42.33s)

...

@robh007 robh007 requested a review from a team July 12, 2019 11:18
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 12, 2019
@bflad bflad added the new-data-source Introduces a new data source. label Jul 12, 2019
@robh007
Copy link
Contributor Author

robh007 commented Jul 17, 2019

Updated tests after receiving feedback on #9321

make testacc ./aws TESTARGS='-run=TestAccDataSourceAwsWafWebAcl'
PASS: TestAccDataSourceAwsWafWebAcl_Basic (26.72s)

ryndaniels
ryndaniels approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @robh007 - thanks for getting the changes based on #9321 in here so quickly! 👍

Output from acceptance testing:

[TestAccDataSourceAwsWafWebAcl_Basic] [Test Output]
=== RUN   TestAccDataSourceAwsWafWebAcl_Basic
=== PAUSE TestAccDataSourceAwsWafWebAcl_Basic
=== CONT  TestAccDataSourceAwsWafWebAcl_Basic
--- PASS: TestAccDataSourceAwsWafWebAcl_Basic (20.26s)
PASS

🚀

@ryndaniels ryndaniels added this to the v2.20.0 milestone Jul 18, 2019
@ryndaniels ryndaniels merged commit 4dae39f into hashicorp:master Jul 18, 2019
bflad added a commit that referenced this pull request Jul 18, 2019
@bflad
Update CHANGELOG formatting for #9320 and #9321
6a4934a
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees

@ryndaniels ryndaniels

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robh007 @ryndaniels @bflad