Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resources: aws_config_organization_custom_rule and aws_config_organization_managed_rule #9716

Merged
merged 3 commits into from
Aug 12, 2019
Merged

New Resources: aws_config_organization_custom_rule and aws_config_organization_managed_rule #9716

merged 3 commits into from
Aug 12, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 10, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9299

Release note for CHANGELOG:

* **New Resource:** `aws_config_organization_custom_rule`
* **New Resource:** `aws_config_organization_managed_rule`

Output from acceptance testing:

    --- PASS: TestAccAWSConfig/OrganizationCustomRule (3029.15s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/InputParameters (305.03s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/MaximumExecutionFrequency (232.54s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/ResourceIdScope (226.23s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/ResourceTypesScope (282.06s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/basic (130.37s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/disappears (141.50s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/errorHandling (155.78s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/ExcludedAccounts (246.06s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/TagValueScope (255.75s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/TriggerTypes (258.28s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/Description (271.57s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/LambdaFunctionArn (231.53s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/TagKeyScope (292.43s)
    --- PASS: TestAccAWSConfig/OrganizationManagedRule (2809.33s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/RuleIdentifier (254.75s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/TagKeyScope (301.58s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/Description (238.37s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/ExcludedAccounts (300.45s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/MaximumExecutionFrequency (234.66s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/ResourceTypesScope (261.44s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/ResourceIdScope (285.29s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/TagValueScope (263.19s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/basic (115.53s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/disappears (176.75s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/errorHandling (150.24s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/InputParameters (227.08s)

@bflad bflad added new-resource Introduces a new resource. service/configservice Issues and PRs that pertain to the configservice service. labels Aug 10, 2019
@bflad bflad added this to the v2.24.0 milestone Aug 10, 2019
@bflad bflad requested a review from a team August 10, 2019 23:31
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 10, 2019
@bflad bflad mentioned this pull request Aug 10, 2019
Closed
@bflad
New Resources: aws_config_organization_custom_rule and aws_config_org…
676f898 
…anization_managed_rule

Reference: #9299

Output from acceptance testing:

```
    --- PASS: TestAccAWSConfig/OrganizationCustomRule (3029.15s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/InputParameters (305.03s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/MaximumExecutionFrequency (232.54s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/ResourceIdScope (226.23s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/ResourceTypesScope (282.06s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/basic (130.37s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/disappears (141.50s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/errorHandling (155.78s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/ExcludedAccounts (246.06s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/TagValueScope (255.75s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/TriggerTypes (258.28s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/Description (271.57s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/LambdaFunctionArn (231.53s)
        --- PASS: TestAccAWSConfig/OrganizationCustomRule/TagKeyScope (292.43s)
    --- PASS: TestAccAWSConfig/OrganizationManagedRule (2809.33s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/RuleIdentifier (254.75s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/TagKeyScope (301.58s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/Description (238.37s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/ExcludedAccounts (300.45s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/MaximumExecutionFrequency (234.66s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/ResourceTypesScope (261.44s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/ResourceIdScope (285.29s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/TagValueScope (263.19s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/basic (115.53s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/disappears (176.75s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/errorHandling (150.24s)
        --- PASS: TestAccAWSConfig/OrganizationManagedRule/InputParameters (227.08s)
```
@bflad bflad force-pushed the f-aws_config_organization_rules branch from a82f045 to 676f898 Compare August 12, 2019 11:27
ryndaniels
ryndaniels approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍐 👀 🚀

website/docs/r/config_organization_managed_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/config_organization_custom_rule.html.markdown Outdated Show resolved Hide resolved
bflad and others added 2 commits August 12, 2019 12:25
@bflad
docs/resource/aws_config_organization_custom_rule: Note Lambda Permis…
87fd3ec 
…sion instead of Configuration Recorder

Found during resource testing, the API concerns itself with the Lambda Permissions when working with Organization Custom Rules and does not return the same errors (as Organization Managed Rules) requiring Configuration Recorders in each account.
@bflad @ryndaniels
Apply suggestions from code review
2ca49ca 
Co-Authored-By: Ryn Daniels <ryn@hashicorp.com>
@bflad bflad merged commit cd515e7 into master Aug 12, 2019
@bflad bflad deleted the f-aws_config_organization_rules branch August 12, 2019 18:20
bflad added a commit that referenced this pull request Aug 12, 2019
@bflad
Update CHANGELOG for #9716
208d494
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/configservice Issues and PRs that pertain to the configservice service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_config_organization_config_rule
2 participants
@bflad @ryndaniels