Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update final_snapshot_identifier in db_instance.html.markdown #9849

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

fffonion
Copy link
Contributor

The description of final_snapshot_identifier is not accurate.
When skip_final_snapshot is by default set to false and final_snapshot_identifier
is omitted, the provider errored with

RDS Cluster FinalSnapshotIdentifier is required when a final snapshot is required

The document is updated to reflect this behaviour

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4910

Release note for CHANGELOG:

- Update documentation of `final_snapshot_identifier` to reflect it's required when 
`skip_final_snapshot` is set to false.

The description of `final_snapshot_identifier` doesn't feel correct to me.
When `skip_final_snapshot` is by default set to false and `final_snapshot_identifier`
is omitted, the provider errored with 
> RDS Cluster FinalSnapshotIdentifier is required when a final snapshot is require

Related: hashicorp#4910
@fffonion fffonion requested a review from a team August 22, 2019 20:23
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. documentation Introduces or discusses updates to documentation. labels Aug 22, 2019
@fffonion fffonion changed the title Update db_instance.html.markdown Update final_snapshot_identifier in db_instance.html.markdown Aug 22, 2019
@ryndaniels ryndaniels self-assigned this Aug 26, 2019
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this clarification @fffonion! 🚀

@ryndaniels ryndaniels added this to the v2.26.0 milestone Aug 26, 2019
@ryndaniels ryndaniels merged commit 512461e into hashicorp:master Aug 26, 2019
@fffonion fffonion deleted the patch-1 branch August 26, 2019 18:23
@ghost
Copy link

ghost commented Aug 29, 2019

This has been released in version 2.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants