Azure Active Directory Service Principals

[tombuildsstuff]

This PR adds support for creating Service Principals associated with an Azure Active Directory Application.

• Resource for Service Principal
• Data Source for Service Principal
• Resource for a Service Principal Key

There's an eventual consistency issue in the Active Directory Application resource, but I can't immediately see a way around that - so that'll be fixed in a follow up PR

Fixes #16

* **New Data Source:** `azurerm_service_principal` [GH-1564]
* **New Resource:** `azurerm_service_principal` [GH-1564]
* **New Resource:** `azurerm_service_principal_password` [GH-1564]

[tiwood]

Hi @tombuildsstuff, I've just created a similar PR (#1570 ). Just want to check how we go ahead?

Additionally I want to discuss what you think is the best way to add access credentials to the service principal object. Initially I've added a access_credential block to my implementation, but maybe a separate resource (azurerm_azuread_service_principal_access_credential) would be more fitting?

[tombuildsstuff]

hey @tiwood

Hi @tombuildsstuff, I've just created a similar PR (#1570 ). Just want to check how we go ahead?

Thanks for the PR #1570 :)

Taking a look through both PR's, it appears this one's slightly further along - as such I'm going to close #1570 in favour of this PR for the moment - I hope you don't mind!

Additionally I want to discuss what you think is the best way to add access credentials to the service principal object. Initially I've added a access_credential block to my implementation, but maybe a separate resource (azurerm_azuread_service_principal_access_credential) would be more fitting?

I've spent a while prototyping both approaches and have come to a similar conclusion that this is better as a separate resource (since this allows for them to be more easily generated using the count syntax, for one thing); as such I've pushed a commit to this PR which adds the separate resource. I also wondered if it'd be worth integrating the azurerm_azurerad_service_principal resource into the azurerm_azuread_application resource, but on reflection I feel that's probably the wrong approach (and ended up leaving it as a separate resource).

One thing that's not included in either of our PR's is support for Service Principal Certificates (although yours contains a "credential_type" field, from what I can see this needs to be a separate resource specifically for Credentials). Since you've been looking into this area anyway - would you be interested in adding support for that instead?

Thanks!

[mbfrahry]

LGTM!

[tombuildsstuff]

Need to fix up one of the tests prior to merging this

[tombuildsstuff]

Ignoring a transitory failure (the eventual consistency issue referred to above) - the Data Source tests pass:

[tombuildsstuff]

Resource tests pass:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!