[WIP] New resource 'azurerm_azuread_service_principal'

[tiwood]

This is a WIP pull request, I'll keep updating here as I'll progress.

• New resource 'azurerm_azuread_service_principal'
• Tests for 'azurerm_azuread_service_principal'
• Data source for 'azurerm_azuread_service_principal'
• Add examples
• Add documentation

Example of the resource:

resource "azurerm_azuread_application" "my_aad_application" {
  name = "my_aad_application"
}

resource "azurerm_azuread_service_principal" "my_service_principal" {
  
  application_id = "${azurerm_azuread_application.my_aad_application.application_id}"

  access_credential {
    credential_type = "password"
    value           = "aiTkVlaAT2wWcphAA"
    start_date      = "2018-10-15T18:00:15+02:00"
    end_date        = "2019-04-15T18:00:15+02:00"
  }

  access_credential {
    credential_type = "password"
    value           = "aiTkVlanvepAT2wWcphAA"
    start_date      = "2018-10-01T18:00:15+02:00"
    end_date        = "2020-04-15T18:00:15+02:00"
  }
}

Up for discussion:

• I still need to decide if I want to use a 'access_credential' block inside the resource, or if I should create a separate resource to create these credentials (azurerm_azuread_service_principal_access_credential). Maybe both?

[tombuildsstuff]

hey @tiwood

Thanks for this PR :)

Taking a look through whilst this PR is off to a good start I'm going to close it in favour of #1564 since that contains the same resources (albeit split out rather than with Passwords nested under the Service Principal resource) and is slightly further along - I hope you don't mind!

One thing that's not included in #1564 that's in this PR is the start of support for Service Principal Certificates - whilst the AzureRM Provider doesn't support authenticating using them at this time (although we plan to change that at some point there's a feature request for that here). Whilst I appreciate we're closing this PR, since you've started looking into this area would you be interested in adding support for Service Principal Certificates instead? From what I can see that'd end up being a new resource azurerm_azuread_service_principal_certificate.

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!