Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expanded tempdb settings in azurerm_mssql_virtual_machine #15707

Open
ScottAtTR opened this issue Mar 4, 2022 · 3 comments
Open

Support expanded tempdb settings in azurerm_mssql_virtual_machine #15707

ScottAtTR opened this issue Mar 4, 2022 · 3 comments
Assignees
Labels
enhancement service/mssql Microsoft SQL Server

Comments

@ScottAtTR
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

SQL Virtual Machines now support tempdb settings for specifying

  • data file count
  • data file initial size
  • data file growth size
  • log file size
  • log file growth size

The below arm template fragment was when creating image MicrosoftSQLServer:sql2019-ws2019:enterprise-gen2:latest.

                "StorageConfigurationSettings": {
                    "DiskConfigurationType": "[parameters('sqlStorageDisksConfigurationType')]",
                    "StorageWorkloadType": "[parameters('sqlStorageWorkloadType')]",
                    "SQLDataSettings": {
                        "LUNs": "[parameters('dataDisksLUNs')]",
                        "DefaultFilePath": "[parameters('dataPath')]"
                    },
                    "SQLLogSettings": {
                        "LUNs": "[parameters('logDisksLUNs')]",
                        "DefaultFilePath": "[parameters('logPath')]"
                    },
                    "SQLTempDbSettings": {
                        "DefaultFilePath": "[parameters('tempDbPath')]",
                        "DataFileCount": "[parameters('dataFileCount')]",
                        "DataFileSize": "[parameters('dataFileSize')]",
                        "DataGrowth": "[parameters('dataGrowth')]",
                        "LogFileSize": "[parameters('logFileSize')]",
                        "LogGrowth": "[parameters('logGrowth')]",
                        "LUNs": "[parameters('tempDisksLUNs')]"
                    },
                    "SQLSystemDbOnDataDisk": "[parameters('SQLSystemDbOnDataDisk')]"
                }

New or Affected Resource(s)

  • azurerm_mssql_virtual_machine

References

@mybayern1974 mybayern1974 added enhancement service/mssql Microsoft SQL Server and removed service/mssql Microsoft SQL Server labels Mar 7, 2022
@manicminer manicminer added the service/mssql Microsoft SQL Server label Mar 8, 2022
@manicminer manicminer self-assigned this Mar 8, 2022
@tikicoder
Copy link
Contributor

Looks like the first part of this is done, and just need merged in
#15835

I actually created an updated based on that PR to include this
https://github.com/tikicoder/terraform-provider-azurerm/blob/sql_virtual_machine-api-upgrade/internal/services/mssql/mssql_virtual_machine_resource.go

I am testing locally presuming it works I Will push the PR.

@tikicoder
Copy link
Contributor

I have created a PR based on some testing that seems to fix the issue.
#15945
My PR builds on the other PR, why reinvent the wheel if the wheel just needs a few improvements.

@tikicoder
Copy link
Contributor

@manicminer please let me know if I can help or if I need to reevaluate my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement service/mssql Microsoft SQL Server
Projects
None yet
Development

No branches or pull requests

4 participants