-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies
: Upgrade sqlvirtualmachine to 2021-11-01-preview
#15835
Conversation
@@ -811,7 +811,7 @@ func flattenSqlVirtualMachineStorageConfigurationSettings(input *sqlvirtualmachi | |||
"disk_type": string(input.DiskConfigurationType), | |||
"data_settings": flattenSqlVirtualMachineStorageSettings(input.SQLDataSettings), | |||
"log_settings": flattenSqlVirtualMachineStorageSettings(input.SQLLogSettings), | |||
"temp_db_settings": flattenSqlVirtualMachineStorageSettings(input.SQLTempDbSettings), | |||
"temp_db_settings": flattenSqlVirtualMachineTempDbSettings(input.SQLTempDbSettings), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type has been changed in the new api version so created a copy of the old expand/flatten
de2d277
to
7d10f36
Compare
Hi @katbyte there seems to be multiple features waiting for the api upgrade, would you be able to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myc2h6o - all tests are failing with this PR:
@katbyte The fixing pr #16519 is merged, updated test result with this change: Among these, the test terraform-provider-azurerm/internal/services/mssql/mssql_virtual_machine_resource.go Lines 397 to 407 in cdd2a57
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚜
This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
To prepare for supporting
instance_settings
mentioned in #15824