Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: remove unused docker_bridge_cidr variable #18119

Closed
1 task done
zioproto opened this issue Aug 25, 2022 · 3 comments · Fixed by #20952
Closed
1 task done

azurerm_kubernetes_cluster: remove unused docker_bridge_cidr variable #18119

zioproto opened this issue Aug 25, 2022 · 3 comments · Fixed by #20952

Comments

@zioproto
Copy link
Contributor

zioproto commented Aug 25, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.2.8

AzureRM Provider Version

3.18.0

Affected Resource(s)/Data Source(s)

azurerm_kubernetes_cluster

Terraform Configuration Files

resource "azurerm_kubernetes_cluster" "main" {
[..CUT..]
network_profile {
    network_plugin     = var.network_plugin
    dns_service_ip     = var.net_profile_dns_service_ip
    docker_bridge_cidr = var.net_profile_docker_bridge_cidr
    network_policy     = var.network_policy
    outbound_type      = var.net_profile_outbound_type
    pod_cidr           = var.net_profile_pod_cidr
    service_cidr       = var.net_profile_service_cidr
  }
[..CUT..]
}

This is a cleanup request

Since 2020 the default AKS runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

It is not possible anymore to create an AKS cluster with Docker runtime.
https://docs.microsoft.com/en-us/azure/aks/cluster-configuration#container-runtime-configuration
Docker is no longer supported as of September 2022

However users of the resource azurerm_kubernetes_cluster are forced to set a value for docker_bridge_cidr because otherwise they cannot set service_cidr:

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#docker_bridge_cidr

178714319-ab977111-4f1b-4249-b282-731a0a081401

This is super confusing to have this technical debt for folks that start using this resource in 2022, and they have no idea why a Docker cidr is needed when Docker is not even used.

References

@zioproto
Copy link
Contributor Author

Hello Folks, all AKS users are receiving this communication. This should be fixed in the provider as soon as possible. It should be possible to do not set docker_bridge_cidr and make this independent from service_cidr.

Screenshot 2023-03-14 at 09 32 57

@github-actions github-actions bot added this to the v3.49.0 milestone Mar 17, 2023
zioproto added a commit to zioproto/terraform-azurerm-aks that referenced this issue Mar 23, 2023
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Related: hashicorp/terraform-provider-azurerm#18119
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

zioproto added a commit to zioproto/terraform-azurerm-aks that referenced this issue Mar 24, 2023
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Related: hashicorp/terraform-provider-azurerm#18119
zioproto added a commit to zioproto/terraform-azurerm-aks that referenced this issue Apr 11, 2023
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Related: hashicorp/terraform-provider-azurerm#18119
lonegunmanb pushed a commit to Azure/terraform-azurerm-aks that referenced this issue Apr 11, 2023
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Related: hashicorp/terraform-provider-azurerm#18119
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.