Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting scale rules #20629

Closed
1 task done
Zizico2 opened this issue Feb 23, 2023 · 7 comments · Fixed by #23294
Closed
1 task done

Setting scale rules #20629

Zizico2 opened this issue Feb 23, 2023 · 7 comments · Fixed by #23294
Labels
enhancement service/container-apps upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Milestone

Comments

@Zizico2
Copy link

Zizico2 commented Feb 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Is support for scale rules in Azure Container Apps planed?

It would also be beneficial if I could use AzApi to fill this gap. But using AzApi in conjunction with AzureRm for this seems broken. The scale rules defined in AzApi never seem to get set. It's happened that they do get set, but then disappear after a following deployment, or just after some time (?). I assume this is a bug. And, according to this comment (#20535 (comment)), weird stuff is happening with scale rules, even when not using AzApi. So I assume the bug is on AzureRm's side.

Created a bug report for this problem: #20631

New or Affected Resource(s)/Data Source(s)

azurerm_container_app

Potential Terraform Configuration

No response

References

No response

@adelinn
Copy link

adelinn commented Mar 8, 2023

@mybayern1974 This looks like a feature request to me, not a bug report.
And from what I've seen in the code it's not a problem with the Microsoft API. Setting scaling rules is just not implemented in the provider. So I would remove upstram/microsoft.
That's probably the reason for the strange behavior described here #20535 (comment)

jsok added a commit to jsok/terraform-provider-azurerm that referenced this issue Apr 4, 2023
jsok added a commit to jsok/terraform-provider-azurerm that referenced this issue Apr 4, 2023
@MartyWind
Copy link

@jsok Thanks for your effort to implement this feature 👌
Would it be possible to set the value for cooldown with this?
https://learn.microsoft.com/en-us/azure/azure-monitor/autoscale/autoscale-understanding-settings

I want unused container apps to scale to zero, but the default cooldown of 5 minutes is just too low.

@jsok
Copy link
Contributor

jsok commented Apr 14, 2023

@jsok Thanks for your effort to implement this feature 👌

Would it be possible to set the value for cooldown with this?

https://learn.microsoft.com/en-us/azure/azure-monitor/autoscale/autoscale-understanding-settings

I want unused container apps to scale to zero, but the default cooldown of 5 minutes is just too low.

I'm not sure I follow. That's not the container apps API...

@ab-revanthgss
Copy link

Any update on this?

@wouter-van-den-meulenhof

We're also waiting for this; currently we need to configure the scalers and their settings by hand. Not a fun excercise.

jsok added a commit to jsok/terraform-provider-azurerm that referenced this issue Jun 12, 2023
@rcskosir rcskosir added enhancement and removed bug labels Jun 29, 2023
@waynebrantley
Copy link

@jsok I see your PR was reviewed with a few 'larger than minor' changes. Any plans to get this out - looks like a great start and would be a nice addition.

Copy link

github-actions bot commented May 6, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/container-apps upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
9 participants